Subject: Re: Improve the HINT message of the ALTER command for postgres_fdw
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: bt21masumurak <bt21masumurak@oss.nttdata.com>,
 Daniel Gustafsson <daniel@yesql.se>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <557d06cebe19081bfcc83ee2affc98d3@oss.nttdata.com>
 <CALj2ACUkZ9FWZA0XgjBeMX-M_Pg2Z=xhvFsy39X6699jDWr5xw@mail.gmail.com>
 <250E9750-57EA-45BA-82A4-787CC61F7309@yesql.se>
 <46864d7a8ca6c2faeb2f9a7a401d47c0@oss.nttdata.com>
 <595194b4-20e1-58a5-4413-c0c7a1aee004@oss.nttdata.com>
 <CALj2ACU7XhadSLpT1x3988RY5ryZRGqo+vwRVF+zmaedzmhi2A@mail.gmail.com>
 <4dbda741-2e88-fd07-c2a6-396d776ccf20@oss.nttdata.com>
 <CALj2ACU_hHxz=Jdfsx6-eRyN872bYfec_gtLb130Umef=oXhQw@mail.gmail.com>
 <33141684-a9bd-aea8-e05c-2826411c70fd@oss.nttdata.com>
 <CALj2ACXxepgwujDzOk3w93kSz5c6j79GYubE1ng1_-y1c2Jt7w@mail.gmail.com>
 <29298fbf-6aec-7700-5cff-74e21d5d0e2e@oss.nttdata.com>
 <CALj2ACU4FNWJ694AHXay3AG+xawRqd9q8w+bw9BR+CUNiOatFg@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <7dec8d9c-57d3-5f8b-8f5e-42febe1e13d2@oss.nttdata.com>
Date: Wed, 27 Oct 2021 01:04:02 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: 
 <CALj2ACU4FNWJ694AHXay3AG+xawRqd9q8w+bw9BR+CUNiOatFg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/7dec8d9c-57d3-5f8b-8f5e-42febe1e13d2%40oss.nttdata.com>
Precedence: bulk


On 2021/10/25 21:27, Bharath Rupireddy wrote:
> On Mon, Oct 25, 2021 at 4:36 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> On 2021/10/25 16:44, Bharath Rupireddy wrote:
>>> Yeah, let's focus on fixing the hint message here and the
>>> alter_foreign_data_wrapper_options_v3.patch LGTM.
>>
>> Thanks! But since v3 changed the error codes, I got rid of those
>> changes and made v4 patch. Attached.
> 
> That's okay as we plan to deal with the error code stuff separately.
> 
>>> Why didn't we have a test case for file_fdw? It looks like the
>>> file_fdw contrib module doesn't have any test cases in its sql
>>> directory. I'm not sure if the module code is being covered in
>>> someother tests.
>>
>> You can see the regression test for file_fdw,
>> in contrib/file_fdw/input and output directories.
> 
> I missed it. Thanks. I see that there are already test cases covering
> error message with hint - "There are no valid options in this
> context."
> 
> The v4 patch LGTM.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION