Message-ID: <7e67b831-9eae-cd19-c96c-c1e59d916498@dunslane.net>
Date: Wed, 8 Dec 2021 09:33:06 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: Readd use of TAP subtests
Content-Language: en-US
To: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>,
 Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <9878e1e2-2ce3-6df0-3498-07d967534f5e@enterprisedb.com>
 <87zgpbnr59.fsf@wibble.ilmari.org>
 <6131CFD1-EC47-41ED-999E-AB28B40DDEAA@yesql.se>
 <87wnkfnq9m.fsf@wibble.ilmari.org>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <87wnkfnq9m.fsf@wibble.ilmari.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/7e67b831-9eae-cd19-c96c-c1e59d916498%40dunslane.net>
Precedence: bulk


On 12/8/21 09:08, Dagfinn Ilmari Mannsåker wrote:
>
> Either way, I think we should be switching tests to done_testing()
> whenever it would otherwise have to adjust the test count, to avoid
> having to do that again and again and again going forward.
>

I'm not so sure. I don't think its necessarily a bad idea to have to
declare how many tests you're going to run. I appreciate it gets hard in
some cases, which is why we have now insisted on a Test::More version
that supports subtests. I suppose we could just take the attitude that
we're happy with however many tests it actually runs, and as long as
they all pass we're good. It just seems slightly sloppy.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com