Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAv4Q-008jYe-IP for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Dec 2023 16:48:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rAv4P-00BXL4-7f for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Dec 2023 16:48:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAv4O-00BXKv-QP for pgsql-hackers@lists.postgresql.org; Wed, 06 Dec 2023 16:48:20 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rAv4M-0096rU-83 for pgsql-hackers@postgresql.org; Wed, 06 Dec 2023 16:48:19 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6ce32821a53so26783b3a.0 for ; Wed, 06 Dec 2023 08:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1701881297; x=1702486097; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=yxHKoZx5qfScbfPr4Ak7Yjj57f/rrkc9IYqRwq3v5AE=; b=ut4NQLb9KPN6Oj1R3X3RIlE0jyimOwF5ZA3fWO9hskYpzzVu5tng0S2dRlIL7KDpgD HBjWdmtNn8qnfiSmZJe91F/tYHHiscoEGE8eUgAo6Ic40cd6G95lEfS+v4aZMS7l+OQb GE5GssD/vuJ3MshVWSvWwlXCWtfVTOcMm+WMk4aREaKkzD8Zr7UW5j5eW1niSV2U9ZM/ DMY+pz3wbuHlO2rAO8nZaEop7obATVkiEucLvyoXfwz/m9RE3Da4K2gwNeKYgJcB4psi xE29StyLWh/yd9aZzy44IlSILOl3GddT98JaV7Zq3+LfJpw2YzG65O0FNDFovxgBh6Tc lP2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701881297; x=1702486097; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yxHKoZx5qfScbfPr4Ak7Yjj57f/rrkc9IYqRwq3v5AE=; b=hxxcKKTeC7wrmo7Qzs93mb2hwkOn34O1Zot4GfGyxuTQjXY8cebLvIFkKPCtI/oI4I BuE8GlxqsvQDS+lNJUTMk/Erd7YZ188Abi7+VQPseokxBUqmdvXqLMtiK2IOuVDO67k4 Xaz4AsegQfGfUuteCGL82AHEcqOZAQgvbnuQENb1et07cPlUiAPNtJhBa0/KP5Jjkunh YEfKYXB2jkzXmTJugBnzQ9UNBZ9Hkk9x62Iy4XMZiyPrHlRBJTk/ED+h0xDDr/B16yEc RdODd6MhP8j3XsjXCQRP7zIMzBobtoyfel7HZ6L8zV1JTcMDSQwrZnb/7K3PGxMnjSnx fn8g== X-Gm-Message-State: AOJu0Yz/5WDI1HFp7bP58KFDwq30tC8PoLuuEvuRSN9f6v5bMQEAyJs5 P6VUjqAMqtaNOWBSsaKeG2LoTg== X-Google-Smtp-Source: AGHT+IEU16fWqCMZRvsi0FXoROStLgPF/fGZJ4xFnpKqHEY/8J6NAu/65AfGCxnq7xU9JI93Cah4pA== X-Received: by 2002:a05:6a00:1503:b0:6cb:cdd0:76f7 with SMTP id q3-20020a056a00150300b006cbcdd076f7mr989531pfu.21.1701881297252; Wed, 06 Dec 2023 08:48:17 -0800 (PST) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id fe9-20020a056a002f0900b006ce35220db0sm185905pfb.202.2023.12.06.08.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 08:48:16 -0800 (PST) Message-ID: <7e786b4dc36d14c7953f1f7d9ddfcdff004e6a6a.camel@j-davis.com> Subject: Re: Change GUC hashtable to use simplehash? From: Jeff Davis To: John Naylor Cc: Andres Freund , Tom Lane , Gurjeet Singh , pgsql-hackers@postgresql.org Date: Wed, 06 Dec 2023 08:48:15 -0800 In-Reply-To: References: <20231117232712.mpnzsho7ydssg2oc@awork3.anarazel.de> <7fee9f31c2e82948fa56fe57d68eecb0cce36f10.camel@j-davis.com> <20231118001003.n2d7tvdgeckun2y6@awork3.anarazel.de> <27a7a289d5b8f42e1b1e79b1bcaeef3a40583bd2.camel@j-davis.com> <20231122205030.v6yllmmj6dgxpg5f@awork3.anarazel.de> <2330615.1700686581@sss.pgh.pa.us> <20231122212221.ahmlio2yfx7jla6z@awork3.anarazel.de> <2334462.1700688476@sss.pgh.pa.us> <20231122223432.lywt4yz2bn7tlp27@awork3.anarazel.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2023-12-06 at 07:39 +0700, John Naylor wrote: > "git grep cstring_hash" found nothing, so not sure what you're > asking. Sorry, I meant string_hash(). Your v5-0002 changes the way hashing works for cstrings, and that means it's no longer equivalent to hash_bytes with strlen. That's probably fine, but someone might assume that they are equivalent. >=20 > In the abstract, I consider (b) to be a layering violation. As a > consequence, the cleverness in (b) is not confined to one or two > places, but is smeared over a whole bunch of places. I find it hard > to > follow. OK. I am fine with (a). Regards, Jeff Davis