Message-ID: <7e8c913b-1bfb-41f1-b5db-c29e2af48daa@uni-muenster.de>
Date: Sun, 1 Feb 2026 14:58:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Additional message in pg_terminate_backend
From: Jim Jones <jim.jones@uni-muenster.de>
To: Kirill Reshke <reshkekirill@gmail.com>,
 Roman Khapov <rkhapov@yandex-team.ru>
Cc: Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@lists.postgresql.org
References: <064E214D-D86F-4917-A0B6-67EAD6BCB24A@yandex-team.ru>
 <CCCDDDB1-4E54-4A02-AE02-41B3CA497B8A@yesql.se>
 <F6DCC9FF-002B-4CD5-9D36-5C8710142958@yandex-team.ru>
 <CALdSSPhU526xXqjsb=BPO689+qFJQDeimWrhOv=ehzveQsZJgw@mail.gmail.com>
 <99f3524c-6aee-4fe2-8f3f-fcf0b67642c2@uni-muenster.de>
Content-Language: de-DE, en-GB
In-Reply-To: <99f3524c-6aee-4fe2-8f3f-fcf0b67642c2@uni-muenster.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/7e8c913b-1bfb-41f1-b5db-c29e2af48daa%40uni-muenster.de>
Precedence: bulk


On 01/02/2026 01:08, Jim Jones wrote:
> As pointed out by Kirill, there is no reason to create
> pg_terminate_backend_msg or pg_cancel_backend_msg. You can simply use
> the existing functions and expand them to use one extra parameter

Since the message's size is limited to BACKEND_MSG_MAX_LEN, shouldn't
you use it to limit msg at pg_terminate_backend[_msg]()? Something like:

Datum pg_terminate_backend(PG_FUNCTION_ARGS)
{
  int pid;
  int timeout; /* milliseconds */
  char msg[BACKEND_MSG_MAX_LEN];

  pid = PG_GETARG_INT32(0);
  timeout = PG_GETARG_INT64(1);
  text_to_cstring_buffer(PG_GETARG_TEXT_PP(2), msg, sizeof(msg));

  return pg_terminate_backend_internal(pid, timeout, msg);
}