Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0VRc-0007NI-DK for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Apr 2017 15:53:32 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d0VRc-00084P-0V for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Apr 2017 15:53:32 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d0VQ6-0005Op-Nt for pgsql-hackers@postgresql.org; Tue, 18 Apr 2017 15:51:58 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d0VQ3-0004MY-KR for pgsql-hackers@postgresql.org; Tue, 18 Apr 2017 15:51:57 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 06A8220C69; Tue, 18 Apr 2017 11:51:54 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Tue, 18 Apr 2017 11:51:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=R0AEjlM+gdEKxrFjw9fUddPQ66cBZ112LXLqQfbSWok=; b=VeltA1j2 OgDmtBX8NWOjUro7lpCTNPmO/123fwuQm8iXzIaWl1GMnNcGysP5HRR3mzBEBevx zZy8qPDqEGLSTrEvlPXu7lYaCxyVfMKJ/a/zvia5zm1FYrbnLtv/SST3+gwZtz0v vDqu1Nsjt2hbtJFeJadpPTD9EZ2K/Fajic7HkGy6DOVz10O5n2L61CySgJ3t5iUE BQQY+9bKnr6+HTFpmxuileESI4/43SFg9LuWzxjHU+r+rkjCPEFR1+BNwtozkssF k64S8EtHDALhcajidpvxI7JN8vM9yDHPWlCK+XQOO9DZQcFpqgX4YypYW6p61H62 cp/EPT7+L3T0gA== X-ME-Sender: X-Sasl-enc: F3JoGmJauE1Sqw+WTVOwOCUzyqCeeMioJ0P0XWYd3aNy 1492530713 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id C670C241E3; Tue, 18 Apr 2017 11:51:53 -0400 (EDT) Subject: Re: identity columns To: Vitaly Burovoy References: <6adbacbf-73bc-dd1a-2033-63409180fd18@2ndquadrant.com> <06a416db-e35b-36d1-7e2f-0affdee24745@2ndquadrant.com> <4b1d703f-818f-00bf-4169-3279af377f3d@2ndquadrant.com> <59d8e32a-14de-6f45-c2b0-bb52e4a7522d@2ndquadrant.com> <21ab7425-ae33-b0af-4177-f2ba88acd93a@2ndquadrant.com> Cc: pgsql-hackers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <7e8fafb2-1949-fd97-cb57-fb1a3fe0ed6e@2ndquadrant.com> Date: Tue, 18 Apr 2017 11:51:50 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 4/7/17 01:26, Vitaly Burovoy wrote: > I've implement SET GENERATED ... IF NOT EXISTS. It must be placed > before other SET options but fortunately it conforms with the > standard. > Since that form always changes the sequence behind the column, I > decided to explicitly write "[NO] CACHE" in pg_dump. > > As a plus now it is possible to rename the sequence behind the column > by specifying SEQUENCE NAME in SET GENERATED. > > I hope it is still possible to get rid of the "ADD GENERATED" syntax. I am still not fond of this change. There is precedent all over the place for having separate commands for creating a structure, changing a structure, and removing a structure. I don't understand what the problem with that is. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers