Message-ID: <7f0bef53cefcf803b479d143ef29817cd7b721c4.camel@postgresql.org>
Subject: Re: Thread-unsafe coding in ecpg
From: Michael Meskes <meskes@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan
	 <andrew.dunstan@2ndquadrant.com>
Cc: "Joshua D. Drake" <jd@commandprompt.com>, Andres Freund
 <andres@anarazel.de>,  "Tsunakawa, Takayuki"
 <tsunakawa.takay@jp.fujitsu.com>, "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Date: Sat, 26 Jan 2019 05:25:03 +0100
In-Reply-To: <18693.1548302004@sss.pgh.pa.us>
References: <24002.1547944649@sss.pgh.pa.us>
	 <d441f5913b147e5b3e0eed4647f9839d926d90fc.camel@postgresql.org>
	 <29905.1548005448@sss.pgh.pa.us> <29984.1548014676@sss.pgh.pa.us>
	 <0A3221C70F24FB45833433255569204D1FB6C47E@G01JPEXMBYT05>
	 <21439.1548037255@sss.pgh.pa.us>
	 <0A3221C70F24FB45833433255569204D1FB6C4FA@G01JPEXMBYT05>
	 <32316.1548040561@sss.pgh.pa.us>
	 <0A3221C70F24FB45833433255569204D1FB6C6C0@G01JPEXMBYT05>
	 <13850.1548090570@sss.pgh.pa.us>
	 <20190121193512.tdmcnic2yjxlufaw@alap3.anarazel.de>
	 <20352.1548101123@sss.pgh.pa.us>
	 <0f02fb0d-0a80-0dad-a01e-e6879d24e48f@commandprompt.com>
	 <27185.1548102332@sss.pgh.pa.us>
	 <cf1f04ba-1cd8-2adf-10dc-d2d04de3331b@2ndQuadrant.com>
	 <38244c62-e1cc-40f5-d567-777540815c16@2ndQuadrant.com>
	 <d06a16bc-52d6-9f0d-2379-21242d7dbe81@2ndQuadrant.com>
	 <25026.1548284495@sss.pgh.pa.us>
	 <62a84a11-5d3e-1238-afd5-ec11ba91bb09@2ndQuadrant.com>
	 <9460.1548299404@sss.pgh.pa.us> <18693.1548302004@sss.pgh.pa.us>
Organization: PostgreSQL
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.4-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> It looks to me like the reason that the ecpg tests went into an
> infinite
> loop is that compat_informix/test_informix.pgc has not considered the
> possibility of repeated statement failures:
> ...

Correct, this was missing a safeguard. 

> I know zip about ecpg coding practices, but wouldn't it be a better
> idea
> to break out of the loop on seeing an error?

I wonder if it would be better to make the test cases use the proper
whenever command instead. That would give us a slightly better
functionality testing I'd say.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL