Subject: Re: logical replication launcher crash on buildfarm
To: Andres Freund <andres@anarazel.de>
References: 
 <CA+TgmobBTZ_eDbTmx-pfUndZDKPBAcj+r_3CQjEHFkp99kE2Yg@mail.gmail.com>
 <e3c35f3a-426d-b1ca-7fe5-9241c2717013@2ndquadrant.com>
 <CA+Tgmoae_obbYapxDhELe852TO1nFGOdVbWiUwa6Gf+ODxjHnQ@mail.gmail.com>
 <0471e978-b121-ad2f-2879-f1694d9a5ce7@2ndquadrant.com>
 <d217ee26-f3d1-4079-0110-3f7ee44ad6b4@2ndquadrant.com>
 <2124fb62-2393-8525-4fe9-b95b1b689d09@2ndquadrant.com>
 <CA+TgmobNi6++NFCQgSay4A05-FNVFfYVKxfBa00zke8vqU1V3Q@mail.gmail.com>
 <09d8ad33-4287-a09b-a77f-77f8761adb5e@2ndquadrant.com>
 <CA+TgmoZktru0SK1b9888gYF=zmX_haRm+6i8rBP0APS6yO8+NA@mail.gmail.com>
 <8ebd3aa3-55eb-1106-7c10-7e7579f94582@2ndquadrant.com>
 <20170401014430.gcmv62sqytge3bdo@alap3.anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Petr Jelinek <petr@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Message-ID: <7f297f95-686f-eed0-5f72-bf525381d5bc@2ndquadrant.com>
Date: Sat, 1 Apr 2017 03:57:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170401014430.gcmv62sqytge3bdo@alap3.anarazel.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 01/04/17 03:44, Andres Freund wrote:
> On 2017-04-01 03:26:01 +0200, Petr Jelinek wrote:
>> On 01/04/17 02:53, Robert Haas wrote:
>>> On Fri, Mar 31, 2017 at 8:32 PM, Petr Jelinek
>>> <petr.jelinek@2ndquadrant.com> wrote:
>>>> Right, changed to BGW_MAXLEN.
>>>
>>> Hmm, I don't know if there's any good reason not to just use strcmp(),
>>> but sure, OK.  Committed and back-patched.
> 
> Cool!
> 
> 
>> Hmm culicidae still fails, this time only in parallel worker code.
>> This  didn't happen on my machine which is strange.
> 
> Interesting.  Did you reproduce the failure before?  I wonder if the
> issue is that you don't build a position independent executable?
> 

I did reproduce the original issue yes, that's how I tested the patch. I
just copy pasted CFLAGS from the buildfarm configuration of culicidae TBH.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers