Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOF5h-0006uR-0S for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Aug 2022 09:11:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oOF5f-0007Ma-Nv for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Aug 2022 09:11:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOF5f-0007MR-00 for pgsql-hackers@lists.postgresql.org; Wed, 17 Aug 2022 09:11:55 +0000 Received: from mail-177131.yeah.net ([123.58.177.131]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oOF5Z-0002RY-Gl for pgsql-hackers@postgresql.org; Wed, 17 Aug 2022 09:11:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Message-ID:Date:MIME-Version:Subject:From; bh=ebC1e XHdrexCw8VgzA0VRwUm7kAhaB3OeC/EujiWbjQ=; b=pnYZWZ9kqtaQxMoPc40E1 GlKeK2k4BR66l+6P5B6skWQSlvWW6NtjmClg6aO/KS13RWjSpOLjTnd+CfQ6t98W 9IB4XMIt/kH1fGjz28B2LFUzXMWKoCXBJFDbjI1GfG0WOu5NNnNu2+AdUUadwGR7 CpCCdMx4bD5vyFEFuRBeWM= Received: from [192.168.1.100] (unknown [221.196.108.142]) by smtp1 (Coremail) with SMTP id ClUQrACn3z7PsPxi2ltlAA--.59708S2; Wed, 17 Aug 2022 17:11:45 +0800 (CST) Content-Type: multipart/mixed; boundary="------------btjUXo1s6OaM06LOClXaG0Tt" Message-ID: <7f498182-6736-8fee-d2fe-452e336de795@yeah.net> Date: Wed, 17 Aug 2022 17:11:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: Bug: When user-defined AM is used, the index path cannot be selected correctly Content-Language: en-US To: Tom Lane Cc: pgsql-hackers References: <1606486.1660701833@sss.pgh.pa.us> From: Quan Zongliang In-Reply-To: <1606486.1660701833@sss.pgh.pa.us> X-CM-TRANSID: ClUQrACn3z7PsPxi2ltlAA--.59708S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gr4xCw1fJFykZFW7WFyUWrg_yoWDWrX_XF 95C3yku39Y9FWxtFW7JFs09rZ7tan5uFWUX3yvvw4fXry5ZFZxArsxWFs3ur17WF4xtFsx ur90v397ZwsrAjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8iZ25UUUUU== X-Originating-IP: [221.196.108.142] X-CM-SenderInfo: htxd06xrqjzxxdqjq5hhdkh0dhw/1tbiFRFgJF6NlJNZgQAAsM List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------btjUXo1s6OaM06LOClXaG0Tt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2022/8/17 10:03, Tom Lane wrote: > Quan Zongliang writes: >> 1. When using extended PGroonga >> ... >> 3. Neither ID = 'f' nor id= 't' can use the index correctly. > > This works fine for btree indexes. I think the actual problem > is that IsBooleanOpfamily only accepts the btree and hash > opclasses, and that's what needs to be improved. Your proposed > patch fails to do that, which makes it just a crude hack that > solves some aspects of the issue (and probably breaks other > things). > > It might work to change IsBooleanOpfamily so that it checks to > see whether BooleanEqualOperator is a member of the opclass. > That's basically what we need to know before we dare generate > substitute index clauses. It's kind of an expensive test > though, and the existing coding assumes that IsBooleanOpfamily > is cheap ... > > regards, tom lane New patch attached. It seems that partitions do not use AM other than btree and hash. Rewrite only indxpath.c and check if it is a custom AM. --------------btjUXo1s6OaM06LOClXaG0Tt Content-Type: text/plain; charset=UTF-8; name="indxpath.patch" Content-Disposition: attachment; filename="indxpath.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2luZHhwYXRoLmMgYi9z cmMvYmFja2VuZC9vcHRpbWl6ZXIvcGF0aC9pbmR4cGF0aC5jCmluZGV4IDdkMTc2ZTdiMDAu LjMwZGY1Y2IyZjYgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2lu ZHhwYXRoLmMKKysrIGIvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BhdGgvaW5keHBhdGguYwpA QCAtMjMsNiArMjMsNyBAQAogI2luY2x1ZGUgImNhdGFsb2cvcGdfb3BlcmF0b3IuaCIKICNp bmNsdWRlICJjYXRhbG9nL3BnX29wZmFtaWx5LmgiCiAjaW5jbHVkZSAiY2F0YWxvZy9wZ190 eXBlLmgiCisjaW5jbHVkZSAiY29tbWFuZHMvZGVmcmVtLmgiCiAjaW5jbHVkZSAibm9kZXMv bWFrZWZ1bmNzLmgiCiAjaW5jbHVkZSAibm9kZXMvbm9kZUZ1bmNzLmgiCiAjaW5jbHVkZSAi bm9kZXMvc3VwcG9ydG5vZGVzLmgiCkBAIC0yMjk1LDcgKzIyOTYsNyBAQCBtYXRjaF9jbGF1 c2VfdG9faW5kZXhjb2woUGxhbm5lckluZm8gKnJvb3QsCiAKIAkvKiBGaXJzdCBjaGVjayBm b3IgYm9vbGVhbi1pbmRleCBjYXNlcy4gKi8KIAlvcGZhbWlseSA9IGluZGV4LT5vcGZhbWls eVtpbmRleGNvbF07Ci0JaWYgKElzQm9vbGVhbk9wZmFtaWx5KG9wZmFtaWx5KSkKKwlpZiAo SXNCb29sZWFuQW1PcGZhbWlseShpbmRleC0+cmVsYW0sIG9wZmFtaWx5KSkKIAl7CiAJCWlj bGF1c2UgPSBtYXRjaF9ib29sZWFuX2luZGV4X2NsYXVzZShyb290LCByaW5mbywgaW5kZXhj b2wsIGluZGV4KTsKIAkJaWYgKGljbGF1c2UpCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9j YXRhbG9nL3BnX29wZmFtaWx5LmggYi9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX29wZmFtaWx5 LmgKaW5kZXggOGRjOWNlMDFiYi4uNWM0Y2M2MTZkOCAxMDA2NDQKLS0tIGEvc3JjL2luY2x1 ZGUvY2F0YWxvZy9wZ19vcGZhbWlseS5oCisrKyBiL3NyYy9pbmNsdWRlL2NhdGFsb2cvcGdf b3BmYW1pbHkuaApAQCAtNTgsNiArNTgsMTIgQEAgREVDTEFSRV9VTklRVUVfSU5ERVhfUEtF WShwZ19vcGZhbWlseV9vaWRfaW5kZXgsIDI3NTUsIE9wZmFtaWx5T2lkSW5kZXhJZCwgb24g cGcKICNkZWZpbmUgSXNCb29sZWFuT3BmYW1pbHkob3BmYW1pbHkpIFwKIAkoKG9wZmFtaWx5 KSA9PSBCT09MX0JUUkVFX0ZBTV9PSUQgfHwgKG9wZmFtaWx5KSA9PSBCT09MX0hBU0hfRkFN X09JRCkKIAorI2RlZmluZSBJc0Jvb2xlYW5BbU9wZmFtaWx5KGFtaWQsIG9wZmFtaWx5KSBc CisJKChvcGZhbWlseSkgPT0gQk9PTF9CVFJFRV9GQU1fT0lEIHx8IChvcGZhbWlseSkgPT0g Qk9PTF9IQVNIX0ZBTV9PSUQgfHwgXAorCQkoKGFtaWQpID49IEZpcnN0Tm9ybWFsT2JqZWN0 SWQgJiYgXAorCQkJCU9pZElzVmFsaWQoR2V0RGVmYXVsdE9wQ2xhc3MoQk9PTE9JRCwgKGFt aWQpKSkpIFwKKwkpCisKICNlbmRpZgkJCQkJCQkvKiBFWFBPU0VfVE9fQ0xJRU5UX0NPREUg Ki8KIAogI2VuZGlmCQkJCQkJCS8qIFBHX09QRkFNSUxZX0ggKi8K --------------btjUXo1s6OaM06LOClXaG0Tt--