public inbox for [email protected]
help / color / mirror / Atom feedFrom: Maksim Milyutin <[email protected]>
To: Thomas Munro <[email protected]>
To: Maxim Orlov <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Palak Chaturvedi <[email protected]>
Cc: Jim Nasby <[email protected]>
Cc: [email protected]
Cc: Nitin Jadhav <[email protected]>
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache
Date: Mon, 29 Apr 2024 21:47:41 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CALfch19pW48ZwWzUoRSpsaV9hqt0UPyaBPC4bOZ4W+c7FF566A@mail.gmail.com>
<CAMm1aWbk-0C460G9ooy2yNSy1riecqvw4F7jPnqvToFZ_s4oGw@mail.gmail.com>
<CALfch1890bL5SddyOpZDC8d-jZFOUGCGbOr+_11jLTwwJ_WEOA@mail.gmail.com>
<CALfch1_s-X3wxeQbYxhXVuWZKBeY5YvU1D+nJxe21ri5iv0qrw@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CALDaNm20+pri5yvEF-4HZqCwRjHB+qjWHLcfanyEjnwgF96z6Q@mail.gmail.com>
<CA+hUKGL9Y3RgK=SjzSwvUnS4-5RcFEXJ3fwqbLCa9bo8g4uOOg@mail.gmail.com>
<CACG=ezbBCXaP_KH3N15_tHSwAcCmHQjTyOVsd2o5qG6B_dPzPg@mail.gmail.com>
<CA+hUKGKGyVjqoaSC7AZrgYKHAk9Nid9G4Ao3ZtL_OtLZDb+_cA@mail.gmail.com>
<CA+hUKG+CjngU9+7mfPsV6tA8Rze9keoV887mHxUL_9qiFUrjJA@mail.gmail.com>
<[email protected]>
On 14.04.2024 21:16, Maksim Milyutin wrote:
> On 07.04.2024 02:07, Thomas Munro wrote:
>
>> So this is the version I plan to commit.
>>
>> +bool
>> +EvictUnpinnedBuffer(Buffer buf)
>> +{
>> ...
>> + /* This will return false if it becomes dirty or someone else pins it. */
>> + result = InvalidateVictimBuffer(desc);
>> +
>> + UnpinBuffer(desc);
>> +
>> + return result;
>> +}
>
>
> Hi, Thomas!
>
> Should not we call at the end the StrategyFreeBuffer() function to add
> target buffer to freelist and not miss it after invalidation?
>
Hello everyone!
Please take a look at this issue, current implementation of
EvictUnpinnedBuffer() IMO is erroneous - evicted buffers are lost
permanently and will not be reused again
--
Best regards,
Maksim Milyutin
view thread (8+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox