Subject: Re: Update minimum SSL version
To: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
References: <b327f8df-da98-054d-0cc5-b76a857cfed9@2ndquadrant.com>
 <224FD25C-BA10-44FA-95AA-F97C35FB3BB0@yesql.se>
 <CABUevEy4meLCVnrTbjU9zoJvRoWUjvmdmUUkaoAqKYkk0MWHYA@mail.gmail.com>
 <20191129125727.GN2505@paquier.xyz> <13786.1575041447@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, Daniel Gustafsson
 <daniel@yesql.se>, pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <7f99c00f-3266-70ea-039f-e666bc5c6d26@2ndquadrant.com>
Date: Mon, 2 Dec 2019 11:39:48 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <13786.1575041447@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-11-29 16:30, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> On Fri, Nov 29, 2019 at 01:40:48PM +0100, Magnus Hagander wrote:
>>> +1. As long as we still have support to change it down if needed, it's a
>>> good thing to ship with a proper default.
> 
>> +1.
> 
> What's the impact going to be on buildfarm members with older openssl
> installations?  Perhaps "none", if they aren't running the ssl test
> suite, but we should be clear about it.

If they aren't running the ssl tests, then none.

We could add an override of ssl_min_protocol_version in 
src/test/ssl/t/SSLServer.pm so that the tests still work with very old 
OpenSSL versions by default.  That might be a good idea.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services