Content-Type: multipart/alternative;
 boundary="------------2EcvMgOL25YbXklHy3SwIU1H"
Message-ID: <7fb11a74-69c6-4f73-b505-0fac9783cc4c@gmail.com>
Date: Sun, 12 Apr 2026 16:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Non-compliant SASLprep implementation for ASCII characters
To: Michael Paquier <michael@paquier.xyz>
Cc: John Naylor <johncnaylorls@gmail.com>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
References: <aaEJ-El2seZHeFcG@paquier.xyz>
 <CANWCAZbgyvx66qfngNvW0n+uEv3=Bak1X5GLPr4sZApuHDPV-g@mail.gmail.com>
 <abt60Gcc4drBlY1N@paquier.xyz>
 <09df9d75-13e7-45fe-89af-33fe118e797b@gmail.com>
 <aduGPnmDabfEKENJ@paquier.xyz>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <aduGPnmDabfEKENJ@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/7fb11a74-69c6-4f73-b505-0fac9783cc4c%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------2EcvMgOL25YbXklHy3SwIU1H
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

12.04.2026 14:47, Michael Paquier wrote:
> On Sun, Apr 12, 2026 at 09:00:00AM +0300, Alexander Lakhin wrote:
>> That is, strlcpy() tries to evaluate strlen() for src, which contains only
>> one byte without null terminator.
> Thanks for the report.  I don't know why skink is not complaining, but
> I do see the failure, and I am able to fix it with the attached.  Does
> it work on your side?

Yes, it works. Thank you for paying attention to the issue!

Maybe it would make sense to find out why skink doesn't detect this (just
in case there are or will be similar defects hiding) before pushing the
fix...

Best regards,
Alexander
--------------2EcvMgOL25YbXklHy3SwIU1H
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">12.04.2026 14:47, Michael Paquier
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:aduGPnmDabfEKENJ@paquier.xyz">
      <pre wrap="" class="moz-quote-pre">On Sun, Apr 12, 2026 at 09:00:00AM +0300, Alexander Lakhin wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">That is, strlcpy() tries to evaluate strlen() for src, which contains only
one byte without null terminator.
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
Thanks for the report.  I don't know why skink is not complaining, but
I do see the failure, and I am able to fix it with the attached.  Does
it work on your side?
</pre>
    </blockquote>
    <br>
    Yes, it works. Thank you for paying attention to the issue!<br>
    <br>
    Maybe it would make sense to find out why skink doesn't detect this
    (just<br>
    in case there are or will be similar defects hiding) before pushing
    the<br>
    fix...<br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------2EcvMgOL25YbXklHy3SwIU1H--