Message-ID: <7fc23473-7f10-5282-711e-34247d089f75@gmail.com>
Date: Wed, 15 Mar 2023 19:31:46 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: optimize several list functions with SIMD intrinsics
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <20230308002502.GA3378449@nathanxps13>
 <20230308185809.GA3552675@nathanxps13>
 <167852767890.628976.10354523915450248589.pgcf@coridan.postgresql.org>
 <20230313214027.GB423713@nathanxps13>
Content-Language: en-US
From: Ankit Kumar Pandey <itsankitkp@gmail.com>
In-Reply-To: <20230313214027.GB423713@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/7fc23473-7f10-5282-711e-34247d089f75%40gmail.com>
Precedence: bulk

Agree with your points Nathan. Just a headup.

> On 14/03/23 03:10, Nathan Bossart wrote:
> On Sat, Mar 11, 2023 at 09:41:18AM +0000, Ankit Kumar Pandey wrote:
>> 1. In list_member_ptr, will it be okay to bring `const ListCell *cell` from 
>> #ifdef USE_NO_SIMD
>> 	const ListCell *cell;
>> #endif
>> to #else like as mentioned below? This will make visual separation between #if cases more cleaner
> I would expect to see -Wdeclaration-after-statement warnings if we did
> this.

This worked fine for me, no warnings on gcc 12.2.0. Not a concern though.

Thanks,

Ankit