Feedback-ID: ie0a040ee:Fastmail
Message-ID: <7fc93f27-8360-48a8-8ca7-0f67d441b188@eisentraut.org>
Date: Mon, 23 Feb 2026 16:53:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: meson: Allow disabling static libraries
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Tristan Partin <tristan@partin.io>
References: <e8aa97db-872b-4087-b073-f296baae948d@eisentraut.org>
 <hbncx2rakvfhnionll4g4y6lxhx23wpr7g4vcncdyocfvlwdbh@e4q7u4pjbuhw>
 <ca252267-dae0-402c-b44c-030e6ee812b0@eisentraut.org>
 <2064894.1771439945@sss.pgh.pa.us>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <2064894.1771439945@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/7fc93f27-8360-48a8-8ca7-0f67d441b188%40eisentraut.org>
Precedence: bulk

On 18.02.26 19:39, Tom Lane wrote:
> I think the attached v3 is about ready to go, with perhaps two
> loose ends for you to deal with:
> 
> * Do we need to document this in the SGML docs?
> 
> * Given that -Ddefault_library=static doesn't actually work and
> I doubt we have any interest in ever making it work, perhaps
> it would be nicer to throw an explicit 'not supported' error.
> As this stands, if you try it you get
> src/interfaces/libpq/meson.build:89:0: ERROR: Unknown variable "libpq_so".
> which looks more like a bug than an intentionally-unsupported option.

Committed with documentation addition and an explicit error for the 
not-supported case.