Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gvrAL-0006Iy-UG
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Feb 2019 22:13:34 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gvrAK-0007xO-KG
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Feb 2019 22:13:32 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gvrAK-0007xH-Cs
	for pgsql-hackers@lists.postgresql.org; Mon, 18 Feb 2019 22:13:32 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gvrAH-0003jl-Tu
	for pgsql-hackers@lists.postgresql.org; Mon, 18 Feb 2019 22:13:32 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x1IMDR0O008010;
	Mon, 18 Feb 2019 17:13:27 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: crash in pg_identify_object_as_address
In-reply-to: <20190218202743.GA12392@alvherre.pgsql>
References: <20190218202743.GA12392@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Mon, 18 Feb 2019 17:27:43 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8008.1550528007.1@sss.pgh.pa.us>
Date: Mon, 18 Feb 2019 17:13:27 -0500
Message-ID: <8009.1550528007@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I just came across a crash while debugging some corrupted system
> catalogs; pg_identify_object_as_address fails to cope with some NULL
> input, causing a crash.  Attached patch fixes it.  Naturally, the output
> array will contain NULL members in the output, but that's better than
> crashing ...

Hm, does this overlap with Paquier's much-delayed patch in
https://commitfest.postgresql.org/22/1947/
?

			regards, tom lane