From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: remove ancient pre-dlopen dynloader code
In-reply-to: <20180816083107.2f5gxbvlsgvnuit4@alap3.anarazel.de>
References: <3e3c7552-978b-486a-1a4a-326ee31d0545@2ndquadrant.com>
 <20180809123059.32g25qn7dgd33iyq@alap3.anarazel.de>
 <26726.1533823423@sss.pgh.pa.us>
 <20180816083107.2f5gxbvlsgvnuit4@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 16 Aug 2018 01:31:07 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8021.1534425734.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 16 Aug 2018 09:22:14 -0400
Message-ID: <8022.1534425734@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> This now generates a super nitpicky warning on at at least some linux +
> clang configurations. I use -Weverything plus a lot of -Wno-*, and this
> change added:
> dynloader.c:7:4: warning: ISO C requires a translation unit to contain a=
t least one declaration [-Wempty-translation-unit]

We've been seeing that (or equivalents) on other platforms for years,
if not decades.  I can't get too excited about it really.

The lazy man's way to get rid of it would be to put something like
"int bogus =3D 0;" in the empty dynloader.c files.  Better would be
to not have the empty .c files at all, but I'm not sure how much
we'd have to contort the Makefiles to support that.

			regards, tom lane