From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Dean Rasheed <dean.a.rasheed@gmail.com>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        Simon Riggs <simon.riggs@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Make name optional in CREATE STATISTICS
In-reply-to: <YttqI6O64wDxGn0K@paquier.xyz>
References: <YtnzFv3/jyVjRrkP@paquier.xyz>
 <20220722130646.3da5oh7tgz5qgooi@alvherre.pgsql>
 <YttqI6O64wDxGn0K@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sat, 23 Jul 2022 12:25:23 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <803079.1658548467.1@sss.pgh.pa.us>
Date: Fri, 22 Jul 2022 23:54:27 -0400
Message-ID: <803080.1658548467@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/803080.1658548467%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> I have just looked at 83011ce, and got what you've done here.  You
> have thrown away reindex_target_multitable and added three parts for
> SCHEMA, DATABASE and SYSTEM instead with their own options, enforcing
> the restriction on CONCURRENTLY at the end of REINDEX SYSTEM in the
> parser rather than indexcmds.c.

That does not seem like an improvement.  In v15:

regression=# REINDEX SYSTEM CONCURRENTLY db;
ERROR:  cannot reindex system catalogs concurrently

As of HEAD:

regression=# REINDEX SYSTEM CONCURRENTLY db;
ERROR:  syntax error at or near "CONCURRENTLY"
LINE 1: REINDEX SYSTEM CONCURRENTLY db;
                       ^

That is not a very helpful error, not even if the man page
doesn't show the syntax as legal.

			regards, tom lane