Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M288794=pgsql-hackers-arkari@postgresql.org>)
 id 1aJlh9-0007wu-EO
 for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Jan 2016 17:28:23 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.84) (envelope-from
 <pgsql-hackers-owner+M288794=pgsql-hackers-arkari@postgresql.org>)
 id 1aJlh9-0003Bv-13
 for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Jan 2016 17:28:23 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <tgl@sss.pgh.pa.us>) id 1aJlh7-0003AY-AI
 for pgsql-hackers@postgresql.org; Thu, 14 Jan 2016 17:28:21 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
 by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <tgl@sss.pgh.pa.us>) id 1aJlh5-0008Em-44
 for pgsql-hackers@postgresql.org; Thu, 14 Jan 2016 17:28:20 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
 by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u0EHSDB4008032;
 Thu, 14 Jan 2016 12:28:13 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>,
 =?utf-8?B?0JLQsNGB0LjQu9GM0LXQsiDQlNC80LjRgtGA0LjQuQ==?=
 <d.vasilyev@postgrespro.ru>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Performance degradation in commit ac1d794
In-reply-to: <20160114172216.GL10941@awork2.anarazel.de>
References: <20151225211326.z4umuafvv27nczya@alap3.anarazel.de>
 <24833.1451078993@sss.pgh.pa.us>
 <20151226112248.uv3qxmroe4va7wke@alap3.anarazel.de>
 <20160114143931.GG10941@awork2.anarazel.de>
 <CA+Tgmoaay7n0HbqH4BS+XhdOOYhvYJ7DqZGrMXvduZM8UUXedQ@mail.gmail.com>
 <20160114155617.GI10941@awork2.anarazel.de>
 <CA+TgmoZ_2EgBCXinHsJn=v8bfg3Y3uXpG1xHiQ8g7yRJzwt3Yg@mail.gmail.com>
 <20160114170604.GJ10941@awork2.anarazel.de>
 <CA+TgmoanS+7wpYZeX1C5Vp1XL56XK7f3mx1T+94QDN0_a+y3Jw@mail.gmail.com>
 <20160114171421.GK10941@awork2.anarazel.de>
 <20160114172216.GL10941@awork2.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
 message dated "Thu, 14 Jan 2016 18:22:16 +0100"
Date: Thu, 14 Jan 2016 12:28:13 -0500
Message-ID: <8031.1452792493@sss.pgh.pa.us>
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> This brings me to something related: I'm wondering if we shouldn't merge
> unix/win32_latch.c.

Well, it's duplicated code on the one hand versus maze-of-ifdefs on the
other.  Feel free to try it and see, but I'm unsure it'd be an improvement.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers