From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jim Jones <jim.jones@uni-muenster.de>
cc: Peter Smith <smithpb2250@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Nikolay Samokhvalov <samokhvalov@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Andrey Borodin <amborodin86@gmail.com>
Subject: Re: [PATCH] Add pretty-printed XML output option
In-reply-to: <906cfd1d-63a0-3cf5-7291-2dadb2e149ff@uni-muenster.de>
References: <2f5df461-dad8-6d7d-4568-08e10608a69b@uni-muenster.de>
 <CANNMO+Kwb4_87G8qDeN+Vk1B1vX3HvgoGW+13fJ-b6rj7qbAww@mail.gmail.com>
 <beb5a47d-4684-4b2f-8647-bacb6bd60acf@uni-muenster.de>
 <CANNMO+L5X2ynyXL2RK7gTVA-pj=Z8o8FCCr6RwLfRK_LinjSbg@mail.gmail.com>
 <d79950fd-b3f5-783c-919a-a95de23c0c2c@enterprisedb.com>
 <4c2efca5-8257-2424-6687-07c65e319e95@uni-muenster.de>
 <CAHut+PtMHeBBZ2zv0Bk7-4KMkSrrxZ9PZxUCzhpwTGVk+8G3cw@mail.gmail.com>
 <2eac4d78-2b20-e8ec-54cc-22a88653a1cc@uni-muenster.de>
 <CAHut+PsgXxbzzsG+VqHUa4Kz3G4B-anNmF3-GENwuUdfMJtowA@mail.gmail.com>
 <fb2a543b-e615-d9ba-8402-909631f9b212@uni-muenster.de>
 <CAHut+Pvryt_+wA7TwKVaaF0e6Pm5LaPZQLKatp=78oFd8vMh3A@mail.gmail.com>
 <6cb296fe-4b49-3691-633e-2e2366997b04@uni-muenster.de>
 <3baf8f25-3bd7-7db5-0b31-e4c92b6269ba@enterprisedb.com>
 <1cbe1087-6acb-2b0a-dc9b-0a2d5b99e466@uni-muenster.de>
 <CAHut+PvBUTf9p+Y6+mpWpz59=3eL_EKQ+7Ysxpa9hYGdncDMdg@mail.gmail.com>
 <532259.1678393296@sss.pgh.pa.us> <906cfd1d-63a0-3cf5-7291-2dadb2e!
 149ff@uni-muenster.de>
Comments: In-reply-to Jim Jones <jim.jones@uni-muenster.de>
	message dated "Fri, 10 Mar 2023 14:30:07 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <803303.1678458776.1@sss.pgh.pa.us>
Date: Fri, 10 Mar 2023 09:32:56 -0500
Message-ID: <803304.1678458776@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/803304.1678458776%40sss.pgh.pa.us>
Precedence: bulk

Jim Jones <jim.jones@uni-muenster.de> writes:
> On 09.03.23 21:21, Tom Lane wrote:
>> I've looked through this now, and have some minor complaints and a major
>> one.  The major one is that it doesn't work for XML that doesn't satisfy
>> IS DOCUMENT.  For example,

> How do you suggest the output should look like?

I'd say a series of node trees, each starting on a separate line.

>> I also suspect that it's outright broken to attach a header claiming
>> the data is now in UTF8 encoding.  If the database encoding isn't
>> UTF8, then either that's a lie or we now have an encoding violation.

> I was mistakenly calling xml_parse with GetDatabaseEncoding(). It now 
> uses the encoding of the given doc and UTF8 if not provided.

Mmmm .... doing this differently from what we do elsewhere does not
sound like the right path forward.  The input *is* (or had better be)
in the database encoding.

			regards, tom lane