Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.12\))
Subject: Re: Fix data checksum processing for temp relations and dropped
 databases
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20260709.161542.46102955322725819.horikyota.ntt@gmail.com>
Date: Thu, 9 Jul 2026 09:56:44 +0200
Cc: Fujii Masao <masao.fujii@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <80447AEF-2E66-48EF-9F68-8D408B541EC1@yesql.se>
References: 
 <CAHGQGwGDHAQw=bmpRzk+EmKzVtxZiD5YDurMUffBMwr6WXugQA@mail.gmail.com>
 <20260709.161542.46102955322725819.horikyota.ntt@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/80447AEF-2E66-48EF-9F68-8D408B541EC1%40yesql.se>
Precedence: bulk

> On 9 Jul 2026, at 09:15, Kyotaro Horiguchi <horikyota.ntt@gmail.com> =
wrote:

> The changes look functionally correct to me.

Agreed.

> 1. In BuildRelationList(), if relations without storage should be
> excluded regardless of whether they are temporary or non-temporary, I
> would personally prefer moving the RELKIND_HAS_STORAGE() check before
> the persistence check. That would make the intent a bit clearer.

Makes sense, though I am fine with either approach.

> 2. In ProcessAllDatabases(), I find it slightly easier to read if the
> dropped-database case is handled explicitly first, perhaps by
> continuing early, so that DATACHECKSUMSWORKER_SUCCESSFUL remains the
> default result for the normal path. I'm not completely sure whether
> that check should go just before or just after
> pgstat_progress_update_param(), though.

I like this suggestion, though I think it should go after the call to
pgstat_progress_update_param since the db in question reached =
ProcessDatabase.
I would add it as an else-if case to the conditional testing we have for
_FAILED and _ABORTED.

--
Daniel Gustafsson