public inbox for [email protected]  
help / color / mirror / Atom feed
From: Chao Li <[email protected]>
To: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix how some lists are displayed by psql \d+
Date: Wed, 21 Jan 2026 16:30:12 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHut+PurJVXBJdzTQvq1YWcSQjsgjQcpdK43SOERyfYkpibjNQ@mail.gmail.com>
References: <CAHut+Pu1puO00C-OhgLnAcECzww8MB3Q8DCsvx0cZWHRfs4gBQ@mail.gmail.com>
	<CAHut+PuZ-SPA87FqhyW9zXnwVu4pPo8pT073qBZAhcFTetWYfg@mail.gmail.com>
	<[email protected]>
	<CAHut+PurJVXBJdzTQvq1YWcSQjsgjQcpdK43SOERyfYkpibjNQ@mail.gmail.com>



> On Jan 21, 2026, at 16:22, Peter Smith <[email protected]> wrote:
> 
> On Wed, Jan 21, 2026 at 7:05 PM Chao Li <[email protected]> wrote:
>> 
>> 
>> 
>>> On Jan 21, 2026, at 10:58, Peter Smith <[email protected]> wrote:
>>> 
>>> A rebase was needed for some more test expected output changes.
>>> 
>>> PSA v2.
>>> 
>>> ======
>>> Kind Regards,
>>> Peter Smith.
>>> Fujitsu Australia
>>> <v2-0002-Fix-to-make-psql-d-lists-of-inherits-look-same-as.patch><v2-0001-Fix-to-make-psql-d-lists-of-partitions-look-same-.patch>
>> 
>> I still see some difference:
>> ```
>> evantest=# \d+ p_test;
>>                                     Partitioned table "public.p_test"
>>  Column  |  Type   | Collation | Nullable | Default | Storage  | Compression | Stats target | Description
>> ----------+---------+-----------+----------+---------+----------+-------------+--------------+-------------
>> id       | integer |           |          |         | plain    |             |              |
>> username | text    |           |          |         | extended |             |              |
>> category | text    |           |          |         | extended |             |              |
>> Partition key: LIST (category)
>> Indexes:
>>    "idx_p_test_id" btree (id)
>> Partitions:
>>    p_test_v1 FOR VALUES IN ('A')
>>    p_test_v2 FOR VALUES IN ('B')
>> ```
>> 
>> The index name is quoted, but the partition names are not.
>> 
> 
> AFAICT
> Indexes are quoted
> Constraints are quoted
> Publications are also quoted
> 
> Partitions are NOT quoted
> Inherits are NOT quoted
> 
> ~
> 
> Please confirm --- So, you are expecting that Partitions and Child
> tables should also be quoted, so that everything looks the same?
> 
> This is scope creep from the original intent of this thread, so I will
> look at doing this in a separate patch 0003.
> 
> ======
> Kind Regards
> Peter Smith.
> Fujitsu Australia

Actually I don’t know the rule, which should be quoted and which should not. Is the inconstancy a blocker?

So, I was just pointing out the inconsistency, and I want to hear a clarification from someone.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/










view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix how some lists are displayed by psql \d+
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox