Received: from maia.hub.org (maia-5.hub.org [200.46.204.29])
	by mail.postgresql.org (Postfix) with ESMTP id 500301337B6C
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Sat, 22 Jan 2011 22:42:37 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024)
	with ESMTP id 78359-03
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Sun, 23 Jan 2011 02:42:32 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id AB46B1337B47
	for <pgsql-hackers@postgresql.org>;
	Sat, 22 Jan 2011 22:42:29 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p0N2gQAf000807;
	Sat, 22 Jan 2011 21:42:26 -0500 (EST)
To: Robert Haas <robertmhaas@gmail.com>
cc: Greg Smith <greg@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>,
	Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
Subject: Re: auto-sizing wal_buffers 
In-reply-to: <AANLkTinU=-8X6cnf1R=9-VQ389cet9TT39aZbMNnBQYQ@mail.gmail.com> 
References: <AANLkTik3mZ3sTfbHQW-1B44NRMkUzRsMnPb8g-HtttVv@mail.gmail.com>
	<AANLkTimQ3+osgAEH4meS97FmLN-4evSTS2W6fctov=jY@mail.gmail.com>
	<AANLkTinhU9EEPGM29S+KH=qK4t-mLhBBNAaLCGQSx-4y@mail.gmail.com>
	<20767.1294964709@sss.pgh.pa.us> <4D314406.3000703@2ndquadrant.com>
	<AANLkTikoUWemGmAmNGHXW8QQoo45sLxzr-aU=rUwshba@mail.gmail.com>
	<4D31D0E4.9000108@2ndquadrant.com>
	<AANLkTikpeVE-XMZL4L4Mi4zUd7S-D1JckO97_wjp8t3M@mail.gmail.com>
	<11561.1295742146@sss.pgh.pa.us> <29279.1295746434@sss.pgh.pa.us>
	<AANLkTin93Pfat3RX9u1zWdnZMraQdTzRPC3kE__BUaiD@mail.gmail.com>
	<AANLkTi=7ZVAD+iDm9RTgg-XiZWU47_dBo9Ev6Xvrwf3_@mail.gmail.com>
	<202.1295748502@sss.pgh.pa.us>
	<AANLkTimR1qFAib3gaJ8q5CtHyPGqkT9-E=CcScUOBbfs@mail.gmail.com>
	<508.1295749488@sss.pgh.pa.us>
	<AANLkTinU=-8X6cnf1R=9-VQ389cet9TT39aZbMNnBQYQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Sat, 22 Jan 2011 21:26:42 -0500"
Date: Sat, 22 Jan 2011 21:42:26 -0500
Message-ID: <806.1295750546@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9,
	T_RP_MATCHES_RCVD=-0.01
X-Spam-Level: 
X-Archive-Number: 201101/2207
X-Sequence-Number: 180044

Robert Haas <robertmhaas@gmail.com> writes:
>> Oh, you're complaining about SetConfigOption, not the assign hooks.

> I was actually complaining about the latter, and then switched gears
> to the former.  I'm an equal-opportunity complainer today, I guess...

It does strike me that we could provide SetConfigOptionInt,
SetConfigOptionBool, and SetConfigOptionReal for the benefit of callers
who'd prefer to pass values in those formats.  They'd still do sprintf
internally, but this would make the call sites a bit cleaner.

In a quick tally, though, I see only a couple of potential callers for
SetConfigOptionInt, perhaps a dozen for SetConfigOptionBool, and none at
all for SetConfigOptionReal.  Hence not sure it's worth the trouble.

			regards, tom lane