Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oQbt3-0006E5-Ox
	for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 21:56:41 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oQbt0-0005iR-Tj
	for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 21:56:38 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oQbt0-0005iI-I6
	for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 21:56:38 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oQbst-0001cz-Oc
	for pgsql-hackers@postgresql.org; Tue, 23 Aug 2022 21:56:37 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 27NLuNVF806689;
	Tue, 23 Aug 2022 17:56:23 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Andres Freund <andres@anarazel.de>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Noah Misch <noah@leadboat.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        samay sharma <smilingsamay@gmail.com>,
        Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: Inconsistencies around defining FRONTEND
In-reply-to: 
 <CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
References: <20220820194550.725755r6fj2ro3rx@awork3.anarazel.de>
 <CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Tue, 23 Aug 2022 17:24:30 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <806687.1661291783.1@sss.pgh.pa.us>
Date: Tue, 23 Aug 2022 17:56:23 -0400
Message-ID: <806688.1661291783@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/806688.1661291783%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> Actually, I think we could fix these pretty easily too. See attached.

Hmm, do these headers still pass headerscheck/cpluspluscheck?

I might quibble a bit with the exact placement of the #ifndef FRONTEND
tests, but overall this looks pretty plausible.

			regards, tom lane