Reply-To: jesper.pedersen@redhat.com
Subject: Re: speeding up planning with partitions
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 David Rowley <david.rowley@2ndquadrant.com>
References: <20181107033207.cdisp33ryrgeidef@alvherre.pgsql>
 <f74d2f85-a9c3-f82d-188a-fcfe77911e78@lab.ntt.co.jp>
 <3be67028-a00a-502c-199a-da00eec8fb6e@lab.ntt.co.jp>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: Red Hat
Message-ID: <806bfbbb-c41e-cc22-7761-841255e8a932@redhat.com>
Date: Fri, 9 Nov 2018 12:43:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <3be67028-a00a-502c-199a-da00eec8fb6e@lab.ntt.co.jp>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Amit,

On 11/9/18 3:55 AM, Amit Langote wrote:
> And here are patches structured that way.  I've addressed some of the
> comments posted by Imai-san upthread.  Also, since David's patch to
> postpone PlannerInfo.total_pages calculation went into the tree earlier
> this week, it's no longer included in this set.
> 

Thanks for doing the split this way. The patch passes check-world.

I ran a SELECT test using hash partitions, and got

        Master    v5
64:    6k        59k
1024:  283       59k

The non-partitioned case gives 77k. The difference in TPS between the 
partition case vs. the non-partitioned case comes down to 
set_plain_rel_size() vs. set_append_rel_size() under 
set_base_rel_sizes(); flamegraphs for this sent off-list.

Best regards,
  Jesper