Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\))
Subject: Re: Fix failing assert in deferred constraint trigger
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHGQGwGvWYHZekXZZ-u94yhtTj5W-iZdG1BwXDKTLTWmCS3xhA@mail.gmail.com>
Date: Fri, 11 Sep 2026 10:32:34 +0800
Cc: Fabrizio Mello <fabrizio@planetscale.com>,
 pgsql-hackers@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8080BBBA-302F-4454-9A20-9535A6F45C7D@gmail.com>
References: 
 <CABo-N97AeMbWuYTWg-3=2DkTR3EkvS+Ft=yEaWB181STsR1mBg@mail.gmail.com>
 <CAHGQGwE46gHsZjJhDgOVBJORQ96KeU2EHraL_PkHiCnkiKMPKw@mail.gmail.com>
 <CAHGQGwGvWYHZekXZZ-u94yhtTj5W-iZdG1BwXDKTLTWmCS3xhA@mail.gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/8080BBBA-302F-4454-9A20-9535A6F45C7D%40gmail.com>
Precedence: bulk


> On Sep 11, 2026, at 09:44, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Wed, Sep 9, 2026 at 12:51=E2=80=AFPM Fujii Masao =
<masao.fujii@gmail.com> wrote:
>> One comment: isn't it be better to add a test for exception handling
>> in a deferred constraint trigger at COMMIT? For example, in =
triggers.sql:
>=20
> I've added this test. Attached is the updated version of the patch.
>=20
> BTW, I found that Patrick Reynolds <patrick@piki.org> is listed in the
> =46rom field of the patch. Does that mean he is the author of the =
patch,
> rather than you? I'm just asking because I need to know who to list in =
the
> Author tag of the commit message.
>=20
> Regards,
>=20
> --=20
> Fujii Masao
> <v2-0001-Fix-failing-assert-in-deferred-constraint-trigger.patch>

V2 LGTM.

One nitpick is that, the fix covers both COMMIT and PREPARE TRANSACTION, =
but v2 only adds a regression test for the COMMIT case. Should we test =
both paths?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/