From: Chao Li <li.evan.chao@gmail.com>
Message-Id: <80A10B63-DD7E-4057-A4EB-E2CA3CA1A796@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_92762432-8BE8-4653-85D9-4B70C8763904"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Set log_lock_waits=on by default
Date: Mon, 8 Sep 2025 10:38:07 +0800
In-Reply-To: <c69a6198a05f3e9d74d8240483cbc6dbbaacb86c.camel@cybertec.at>
Cc: Shinya Kato <shinya11.kato@gmail.com>,
 Michael Banck <mbanck@gmx.net>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Nathan Bossart <nathandbossart@gmail.com>,
 pgsql-hackers@lists.postgresql.org
To: Laurenz Albe <laurenz.albe@cybertec.at>
References: <b8b8502915e50f44deb111bc0b43a99e2733e117.camel@cybertec.at>
 <659ffa38.170a0220.eea6a.28fc@mx.google.com>
 <65b146b9.170a0220.c645b.0891@mx.google.com>
 <20240206165343.GA3841415@nathanxps13> <524751.1707240550@sss.pgh.pa.us>
 <6698edb4.5d0a0220.df6fa.5b59@mx.google.com>
 <5dc4e037f60467da7bf7d17b10f6ec632a7c9095.camel@cybertec.at>
 <a459b7d045775784617897592632a6eade915def.camel@cybertec.at>
 <CAOzEurS0jbDrjmVFgE4QQ_O0bnDtJMaaFsy3=pX0RLYXBcjVpg@mail.gmail.com>
 <c69a6198a05f3e9d74d8240483cbc6dbbaacb86c.camel@cybertec.at>
Archived-At: 
 <https://www.postgresql.org/message-id/80A10B63-DD7E-4057-A4EB-E2CA3CA1A796%40gmail.com>
Precedence: bulk


--Apple-Mail=_92762432-8BE8-4653-85D9-4B70C8763904
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Sep 8, 2025, at 05:46, Laurenz Albe <laurenz.albe@cybertec.at> =
wrote:
>=20
> On Thu, 2025-09-04 at 14:12 +0900, Shinya Kato wrote:
>> Due to 635998965 [0], you need to change guc_parameters.dat instead =
of
>> guc_tables.c.
>=20
> Thanks for pointing that out to me!
> Here is an updated patch.
>=20
> Yours,
> Laurenz Albe
> <v2-0001-Default-to-log_lock_waits-on.patch>


I am hesitate to support this change. I agree log_lock_waits is a =
powerful tool, but it=E2=80=99s more like a diagnostic tool. On a =
high-concurrency system with many tractions running at the same time, it =
may quickly fill up log files and make it difficult to find other =
errors. So, we usually only turn it on when needed, and turn it off once =
debugging is done.

But v2 code looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


--Apple-Mail=_92762432-8BE8-4653-85D9-4B70C8763904
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;"><br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>On Sep 8, 2025, at 05:46, Laurenz Albe =
&lt;laurenz.albe@cybertec.at&gt; wrote:</div><br =
class=3D"Apple-interchange-newline"><div><div>On Thu, 2025-09-04 at =
14:12 +0900, Shinya Kato wrote:<br><blockquote type=3D"cite">Due to =
635998965 [0], you need to change guc_parameters.dat instead =
of<br>guc_tables.c.<br></blockquote><br>Thanks for pointing that out to =
me!<br>Here is an updated patch.<br><br>Yours,<br>Laurenz Albe<br><span =
id=3D"cid:260CEAE0-6C46-4368-A609-ECB06B47FB06">&lt;v2-0001-Default-to-log=
_lock_waits-on.patch&gt;</span></div></div></blockquote></div><div><br></d=
iv><div>I am hesitate to support this change. I agree log_lock_waits is =
a powerful tool, but it=E2=80=99s more like a diagnostic tool. On a =
high-concurrency system with many tractions running at the same time, it =
may quickly fill up log files and make it difficult to find other =
errors. So, we usually only turn it on when needed, and turn it off once =
debugging is done.</div><div><br></div><div>But v2 code looks good to =
me.</div><div><br></div>Best regards,<br><div>
<div dir=3D"auto" style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, =
0); letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none; overflow-wrap: =
break-word; -webkit-nbsp-mode: space; line-break: =
after-white-space;"><div>--</div><div>Chao Li (Evan)<br>HighGo Software =
Co., Ltd.<br>https://www.highgo.com/</div><div><br></div></div><br =
class=3D"Apple-interchange-newline"><br =
class=3D"Apple-interchange-newline">

</div>
<br></body></html>=

--Apple-Mail=_92762432-8BE8-4653-85D9-4B70C8763904--