Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Serverside SNI support in libpq
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <aLT9xVsTVp0j3zWy@paquier.xyz>
Date: Tue, 2 Sep 2025 14:48:43 +0200
Cc: Andres Freund <andres@anarazel.de>,
 Jacob Champion <jacob.champion@enterprisedb.com>,
 Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <80F4F8F4-8E4F-4B6F-866B-D837057C1192@yesql.se>
References: <88986722-5A72-4DEC-8750-BDBF67FF8C01@yesql.se>
 <CAOYmi+nYV6Rr9BY4YfYyVdiQ5TzMZray6QPXwiO3pYSaow+-Tg@mail.gmail.com>
 <7E77028B-5A3A-436B-9046-8E9992E9F94A@yesql.se>
 <Z1jeINLtB05YMVOY@paquier.xyz>
 <E51258CD-C7B2-4BB1-AB9C-A3DD2B6592D0@yesql.se>
 <F4222274-15C0-40E4-84FB-8FC1355BB8B2@yesql.se>
 <CAOYmi+mSrV8hRaQkvGDf1Df4cmpv5SeTbTxppyxeonMe6MW8nA@mail.gmail.com>
 <0BC5B9B1-6503-4563-AAC6-33DEF264AE3F@yesql.se>
 <aa7gx3mychf3m2g67mbslzbxjy3if4enpcflstoa5pol3432x5@ugqz45gsvurq>
 <F585452A-1F69-4658-A7E8-D1273AC663ED@yesql.se>
 <aLT9xVsTVp0j3zWy@paquier.xyz>
To: Michael Paquier <michael@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/80F4F8F4-8E4F-4B6F-866B-D837057C1192%40yesql.se>
Precedence: bulk

> On 1 Sep 2025, at 03:58, Michael Paquier <michael@paquier.xyz> wrote:
>=20
> On Wed, Aug 27, 2025 at 09:49:34PM +0200, Daniel Gustafsson wrote:
>> When looking into why the SNI tests failed on Windows I think I found =
a
>> pre-existing issue that we didn't have tests for, which my patch =
added tests
>> for and thus broke.
>>=20
>> The test I added was to check restarting and reloading with ssl =
passphrase
>> commands (which we do have testcoverage for) with a subsequent =
connection test
>> to ensure it didn't just work to start the cluster.
>=20
> Would this part be better if extracted from the main patch and then
> backpatched?  Even if not backpatched, a split would be cleaner on
> HEAD, I assume, leading to less fuzz with the main patch.

Yes, that's my plan, just wanted to float it here first to see if I was
thinking about it all wrong.  I will raise it on its own thread on =
-hackers.
The backpatchable portion is probably limited to a docs entry clarifying =
the
behaviour on Windows.

--
Daniel Gustafsson