Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pya6q-0006Lm-8j for pgsql-hackers@arkaria.postgresql.org; Mon, 15 May 2023 15:27:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pya6o-0000Rx-Rf for pgsql-hackers@arkaria.postgresql.org; Mon, 15 May 2023 15:27:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pya6o-0000Ro-Dx for pgsql-hackers@lists.postgresql.org; Mon, 15 May 2023 15:27:34 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1pya6k-002tkL-Vf for pgsql-hackers@postgresql.org; Mon, 15 May 2023 15:27:33 +0000 Received: from mail.postgrespro.ru (webmail.mstn.postgrespro.ru [192.168.2.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id E87ADE20FDA; Mon, 15 May 2023 18:28:01 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1684164481; bh=AjojGkhz14SkTqyMBiKJDHsiFvQE20P5KzG/bXHyDa4=; h=Date:From:To:Subject:User-Agent:Message-ID:From; b=GEMs15vc/yQP72QRMWNtpaJLLQElstJUZCfOYpPCUVStB/4WcsY7ac5iZQgfvQeWK ufgeNmwvWufv1YEOjaeAS95ZP5vnudHL498b546FO/jJrHha3MAEvDabpWIOAP12sy pdRMmQ9cova//ZgoFYdIqjUNegCjmcsEHFxA2GB7lYv2phlCDsM35JXP6KoO+0YEvI zMw3S0NXKOy1GghiI3xf9jEKg9bjuJCtx9sHWC9f1m3dSLmq4HyAisX8JaPFIWroVF bQqq5TZwN28HALupdj2fyaNOQ1eB6BcmYrA7Xx1r/l8TMrBv/cPOi3MKL/SaLoV+eF yMh6hIFm7nUeQ== MIME-Version: 1.0 Date: Mon, 15 May 2023 18:27:29 +0300 From: Marina Polyakova To: pgsql-hackers@postgresql.org, exclusion@gmail.com Subject: Conflict between regression tests namespace & transactions due to recent changes User-Agent: Roundcube Webmail/1.4.11 Message-ID: <80d0201636665d82185942e7112257b4@postgrespro.ru> X-Sender: m.polyakova@postgrespro.ru Organization: Postgres Professional Content-Type: multipart/mixed; boundary="=_b04194031af6f8a53289abf768fd1810" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_b04194031af6f8a53289abf768fd1810 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hello, hackers! When running tests for version 15, we found a conflict between regression tests namespace & transactions due to recent changes [1]. diff -w -U3 .../src/test/regress/expected/transactions.out .../src/bin/pg_upgrade/tmp_check/results/transactions.out --- .../src/test/regress/expected/transactions.out ... +++ .../src/bin/pg_upgrade/tmp_check/results/transactions.out ... @@ -899,6 +899,9 @@ RESET default_transaction_read_only; DROP TABLE abc; +ERROR: cannot drop table abc because other objects depend on it +DETAIL: view test_ns_schema_2.abc_view depends on table abc +HINT: Use DROP ... CASCADE to drop the dependent objects too. -- Test assorted behaviors around the implicit transaction block created -- when multiple SQL commands are sent in a single Query message. These -- tests rely on the fact that psql will not break SQL commands apart at a ... IIUC the conflict was caused by +SET search_path to public, test_ns_schema_1; +CREATE SCHEMA test_ns_schema_2 + CREATE VIEW abc_view AS SELECT a FROM abc; because the parallel regression test transactions had already created the table abc and was trying to drop it. ISTM the patch diff.patch fixes this problem... [1] https://github.com/postgres/postgres/commit/dbd5795e7539ec9e15c0d4ed2d05b1b18d2a3b09 -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --=_b04194031af6f8a53289abf768fd1810 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=diff.patch Content-Disposition: attachment; filename=diff.patch; size=2091 ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvbmFtZXNwYWNlLm91dCBiL3Ny Yy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvbmFtZXNwYWNlLm91dAppbmRleCBhNjJmZDhkZWQwMTVl NmVlNTY3ODRlNDM0MWU1YWMxYTRlZDU2MjFmLi5iY2I2YTc1Y2YyMzBmZGMzMGY3MjgyMDFjMmEy YmFlZjE4MzhlZDE4IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL25hbWVz cGFjZS5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9uYW1lc3BhY2Uub3V0CkBA IC0zNSwxMCArMzUsMTUgQEAgU0hPVyBzZWFyY2hfcGF0aDsKIAogLS0gdmVyaWZ5IHRoYXQgdGhl IGNvcnJlY3Qgc2VhcmNoX3BhdGggcHJlc2VydmVkCiAtLSBhZnRlciBjcmVhdGluZyB0aGUgc2No ZW1hIGFuZCBvbiBjb21taXQKKy0tIGNyZWF0ZSB5b3VyIHRhYmxlIHRvIG5vdCB1c2UgdGhlIHNh bWUgdGFibGUgZnJvbSB0cmFuc2FjdGlvbnMgdGVzdAogQkVHSU47CiBTRVQgc2VhcmNoX3BhdGgg dG8gcHVibGljLCB0ZXN0X25zX3NjaGVtYV8xOwogQ1JFQVRFIFNDSEVNQSB0ZXN0X25zX3NjaGVt YV8yCi0gICAgICAgQ1JFQVRFIFZJRVcgYWJjX3ZpZXcgQVMgU0VMRUNUIGEgRlJPTSBhYmM7Cisg ICAgICAgQ1JFQVRFIFZJRVcgYWJjX3ZpZXcgQVMgU0VMRUNUIGEgRlJPTSBhYmMKKyAgICAgICBD UkVBVEUgVEFCTEUgYWJjICgKKyAgICAgICAgICAgICAgYSBzZXJpYWwsCisgICAgICAgICAgICAg IGIgaW50IFVOSVFVRQorICAgICAgICk7CiBTSE9XIHNlYXJjaF9wYXRoOwogICAgICAgIHNlYXJj aF9wYXRoICAgICAgICAKIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkBAIC01Myw3ICs1OCw5 IEBAIFNIT1cgc2VhcmNoX3BhdGg7CiAoMSByb3cpCiAKIERST1AgU0NIRU1BIHRlc3RfbnNfc2No ZW1hXzIgQ0FTQ0FERTsKLU5PVElDRTogIGRyb3AgY2FzY2FkZXMgdG8gdmlldyB0ZXN0X25zX3Nj aGVtYV8yLmFiY192aWV3CitOT1RJQ0U6ICBkcm9wIGNhc2NhZGVzIHRvIDIgb3RoZXIgb2JqZWN0 cworREVUQUlMOiAgZHJvcCBjYXNjYWRlcyB0byB0YWJsZSB0ZXN0X25zX3NjaGVtYV8yLmFiYwor ZHJvcCBjYXNjYWRlcyB0byB2aWV3IHRlc3RfbnNfc2NoZW1hXzIuYWJjX3ZpZXcKIC0tIHZlcmlm eSB0aGF0IHRoZSBvYmplY3RzIHdlcmUgY3JlYXRlZAogU0VMRUNUIENPVU5UKCopIEZST00gcGdf Y2xhc3MgV0hFUkUgcmVsbmFtZXNwYWNlID0KICAgICAoU0VMRUNUIG9pZCBGUk9NIHBnX25hbWVz cGFjZSBXSEVSRSBuc3BuYW1lID0gJ3Rlc3RfbnNfc2NoZW1hXzEnKTsKZGlmZiAtLWdpdCBhL3Ny Yy90ZXN0L3JlZ3Jlc3Mvc3FsL25hbWVzcGFjZS5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9u YW1lc3BhY2Uuc3FsCmluZGV4IDM0NzRmNWVjZjQyMTUwNjhmZDg5ZWM1MmY5ZWU4Yjk1ZGRmZjM2 YmIuLjk1YjllZDdiMDA4MDcyMjJlOTRlMzAyMjEzNDhmNTgwMzljNjMyNTcgMTAwNjQ0Ci0tLSBh L3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL25hbWVzcGFjZS5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVz cy9zcWwvbmFtZXNwYWNlLnNxbApAQCAtMjgsMTAgKzI4LDE2IEBAIFNIT1cgc2VhcmNoX3BhdGg7 CiAKIC0tIHZlcmlmeSB0aGF0IHRoZSBjb3JyZWN0IHNlYXJjaF9wYXRoIHByZXNlcnZlZAogLS0g YWZ0ZXIgY3JlYXRpbmcgdGhlIHNjaGVtYSBhbmQgb24gY29tbWl0CistLSBjcmVhdGUgeW91ciB0 YWJsZSB0byBub3QgdXNlIHRoZSBzYW1lIHRhYmxlIGZyb20gdHJhbnNhY3Rpb25zIHRlc3QKIEJF R0lOOwogU0VUIHNlYXJjaF9wYXRoIHRvIHB1YmxpYywgdGVzdF9uc19zY2hlbWFfMTsKIENSRUFU RSBTQ0hFTUEgdGVzdF9uc19zY2hlbWFfMgotICAgICAgIENSRUFURSBWSUVXIGFiY192aWV3IEFT IFNFTEVDVCBhIEZST00gYWJjOworICAgICAgIENSRUFURSBWSUVXIGFiY192aWV3IEFTIFNFTEVD VCBhIEZST00gYWJjCisKKyAgICAgICBDUkVBVEUgVEFCTEUgYWJjICgKKyAgICAgICAgICAgICAg YSBzZXJpYWwsCisgICAgICAgICAgICAgIGIgaW50IFVOSVFVRQorICAgICAgICk7CiBTSE9XIHNl YXJjaF9wYXRoOwogQ09NTUlUOwogU0hPVyBzZWFyY2hfcGF0aDsK --=_b04194031af6f8a53289abf768fd1810--