Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGke0-0006Ju-Ol for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Jul 2023 18:20:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qGkd1-00015O-Gx for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Jul 2023 18:19:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGkd1-00015F-7e for pgsql-hackers@lists.postgresql.org; Tue, 04 Jul 2023 18:19:55 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qGkcw-002CGN-Kx for pgsql-hackers@postgresql.org; Tue, 04 Jul 2023 18:19:54 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 286BC1BF206; Tue, 4 Jul 2023 18:19:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------jEiVTMjEwyxXTourrPMVwi0F" Message-ID: <81023744-772d-889b-99b8-bd1d58bd761b@dunslane.net> Date: Tue, 4 Jul 2023 14:19:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US From: Andrew Dunstan To: Daniel Gustafsson Cc: PostgreSQL Hackers References: <666ac55b-3400-fb2c-2cea-0281bf36a53c@dunslane.net> <76f33a1f-ddce-80a6-6f39-fefa0668f4a6@dunslane.net> <3AC47E65-02A0-42BF-8A3E-B38FD09FE702@yesql.se> <94341cbe-9491-60e9-f01a-7ed770295cfa@dunslane.net> Subject: Re: pg_basebackup check vs Windows file path limits In-Reply-To: <94341cbe-9491-60e9-f01a-7ed770295cfa@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------jEiVTMjEwyxXTourrPMVwi0F Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-07-03 Mo 11:18, Andrew Dunstan wrote: > > > On 2023-07-03 Mo 10:16, Daniel Gustafsson wrote: >>> On 3 Jul 2023, at 16:12, Andrew Dunstan wrote: >>> I've pushed a better solution, which creates the file via a short symlink. Experimentation on fairywren showed this working. >> The buildfarm seems a tad upset after this? >> > > Yeah :-( > > I think it should be fixing itself now. > > > But sadly we're kinda back where we started. fairywren is failing on REL_16_STABLE. Before the changes the failure occurred because the test script was unable to create the file with a path > 255. Now that we have a way to create the file the test for pg_basebackup to reject files with names > 100 fails, I presume because the server can't actually see the file. At this stage I'm thinking the best thing would be to skip the test altogether on windows if the path is longer than 255. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------jEiVTMjEwyxXTourrPMVwi0F Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

On 2023-07-03 Mo 11:18, Andrew Dunstan wrote:

On 2023-07-03 Mo 10:16, Daniel Gustafsson wrote:

On 3 Jul 2023, at 16:12, Andrew Dunstan <andrew@dunslane.net> wrote:

I've pushed a better solution, which creates the file via a short symlink. Experimentation on fairywren showed this working.

The buildfarm seems a tad upset after this?

Yeah :-(

I think it should be fixing itself now.

But sadly we're kinda back where we started. fairywren is failing on REL_16_STABLE. Before the changes the failure occurred because the test script was unable to create the file with a path > 255. Now that we have a way to create the file the test for pg_basebackup to reject files with names > 100 fails, I presume because the server can't actually see the file. At this stage I'm thinking the best thing would be to skip the test altogether on windows if the path is longer than 255.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

--------------jEiVTMjEwyxXTourrPMVwi0F--