Message-ID: <811d6f42e5481935943556b692859aae9146d4c9.camel@j-davis.com>
Subject: Re: Expanding HOT updates for expression and partial indexes
From: Jeff Davis <pgsql@j-davis.com>
To: Greg Burd <greg@burd.me>, Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: Sun, 15 Mar 2026 14:11:53 -0700
In-Reply-To: <91f4dbe2-21ed-49f3-bebe-270f9bbec9d5@app.fastmail.com>
References: <fc17cbe85c24ff9d3cf43bfb37e6ca0d483fb2b4.camel@j-davis.com>
	 <e1d06b18-2ebb-466e-bc0f-5d426d17a32e@app.fastmail.com>
	 <akciabcu3b2hchj7adxhu4kovfaozp2pcn2z7sdljfthxcyg4o@7e6sfyzipvyy>
	 <b8e07500-587d-4360-8f9e-89b14d1c0edc@app.fastmail.com>
	 <bce13827-5f98-4d79-b779-ac5fff2b7668@app.fastmail.com>
	 <c435d703af02097ec19680c2f8d4479292a3d176.camel@j-davis.com>
	 <9bb9bdd6-e1fe-48fe-837d-4d0289396f1c@app.fastmail.com>
	 <bed3fd08-ebfd-4980-801e-bff245a27dd7@app.fastmail.com>
	 <ff2276c5-28f7-4e09-a6ae-40137ceddb67@app.fastmail.com>
	 <872b875c-0aa4-4269-9c84-532227b32361@app.fastmail.com>
	 <abMjC0jifWB0cs5F@nathan>
	 <91f4dbe2-21ed-49f3-bebe-270f9bbec9d5@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.3-0ubuntu1.1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/811d6f42e5481935943556b692859aae9146d4c9.camel%40j-davis.com>
Precedence: bulk

On Thu, 2026-03-12 at 17:31 -0400, Greg Burd wrote:
> Other than the heap_modify_tuple() calls I don't know of something
> that allows for direct changes but that doesn't matter, 0002 will
> scan and pick up those attributes even if we introduce a new
> modification path in the future (as intended).

Why do extra work in ExecBRUpdateTriggers() to eliminate the false
negative case if we don't rely on it anyway? If we do need to rely on
it in subsequent patches, then we need to be sure, right?

I guess I'm confused about whether 0002 is introducing a new guarantee
or if it's just a convenient place to eliminate one source of false
negatives.

Regards,
	Jeff Davis