Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oAg3z-0003U1-5I
	for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Jul 2022 23:10:07 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oAg3x-0006ll-Is
	for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Jul 2022 23:10:05 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oAg3x-0006lc-9x
	for pgsql-hackers@lists.postgresql.org; Sun, 10 Jul 2022 23:10:05 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oAg3u-0000Ly-9H
	for pgsql-hackers@postgresql.org; Sun, 10 Jul 2022 23:10:04 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26AN9vf3815832;
	Sun, 10 Jul 2022 19:09:58 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        David Rowley <dgrowleyml@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically generating node support functions
In-reply-to: <20220710214622.haiektrjzisob6rl@awork3.anarazel.de>
References: <1294462.1656875649@sss.pgh.pa.us>
 <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com>
 <1593978.1656953960@sss.pgh.pa.us>
 <b53b92e0-1153-a31a-8c52-157fa2e07771@enterprisedb.com>
 <2592455.1657140387@sss.pgh.pa.us>
 <b9acf63c-6693-d87c-f010-ca8ad502a39f@enterp! risedb.com>
 <3302658.1657288366@sss.pgh.pa.us> <611d2e!
 93-6330-47fa-0970-72316aed50f2@enterprisedb.com>
 <3488143.1657310625@sss.pgh.pa.us>
 <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com>
 <20220710214622.haiektrjzisob6rl@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 10 Jul 2022 14:46:22 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <815830.1657494597.1@sss.pgh.pa.us>
Date: Sun, 10 Jul 2022 19:09:57 -0400
Message-ID: <815831.1657494597@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/815831.1657494597%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I was just rebasing meson ontop of this and was wondering whether the input
> filenames were in a particular order:

That annoyed me too.  I think it's sensible to list the "main" input
files first, but I'd put them in our traditional pipeline order:

> 	nodes/nodes.h \
> 	nodes/primnodes.h \
> 	nodes/parsenodes.h \
> 	nodes/pathnodes.h \
> 	nodes/plannodes.h \
> 	nodes/execnodes.h \

The rest could probably be alphabetical.  I was also wondering if
all of them really need to be read at all --- I'm unclear on what
access/sdir.h is contributing, for example.

			regards, tom lane