Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1s4mMg-000vxw-Vn
	for pgsql-hackers@arkaria.postgresql.org; Wed, 08 May 2024 18:50:06 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1s4mMf-002PJ9-AS
	for pgsql-hackers@arkaria.postgresql.org; Wed, 08 May 2024 18:50:05 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1s4mMf-002PJ1-13
	for pgsql-hackers@lists.postgresql.org; Wed, 08 May 2024 18:50:05 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1s4mMc-0003zW-8n
	for pgsql-hackers@postgresql.org; Wed, 08 May 2024 18:50:04 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 448InwCH818512;
	Wed, 8 May 2024 14:49:58 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers@postgresql.org
Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
In-reply-to: <20240508183850.GA2824188@nathanxps13>
References: <20240503171348.GA1731524@nathanxps13> <677ed9ca-8653-4c27-80ca-0ea763f0f21f@eisentraut.org> <20240508183850.GA2824188@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Wed, 08 May 2024 13:38:50 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <818510.1715194198.1@sss.pgh.pa.us>
Date: Wed, 08 May 2024 14:49:58 -0400
Message-ID: <818511.1715194198@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/818511.1715194198%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Thanks for looking.  I noticed that the version check is unnecessary since
> we always use the new binary's pg_dump[all], so I removed that in v2.

+1

			regards, tom lane