Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p75Om-00051P-Id for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Dec 2022 01:57:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p75Ol-0001ci-Eo for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Dec 2022 01:56:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p75Ol-0001cH-6H for pgsql-hackers@lists.postgresql.org; Mon, 19 Dec 2022 01:56:59 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p75Oh-0008Iv-Mg for pgsql-hackers@lists.postgresql.org; Mon, 19 Dec 2022 01:56:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2BJ1umvL819273; Sun, 18 Dec 2022 20:56:48 -0500 From: Tom Lane To: "Anton A. Melnikov" cc: PostgreSQL Hackers Subject: Re: [BUG] pg_upgrade test fails from older versions. In-reply-to: <49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru> References: <49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru> Comments: In-reply-to "Anton A. Melnikov" message dated "Mon, 19 Dec 2022 03:50:19 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <819271.1671415008.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 18 Dec 2022 20:56:48 -0500 Message-ID: <819272.1671415008@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk "Anton A. Melnikov" writes: > 2) In 60684dd83 and b5d63824 there are two changes in the set of specifi= c privileges. > The thing is that in the privileges.sql test there is REVOKE DELETE comm= and > which becomes pair of REVOKE ALL and GRANT all specific privileges excep= t DELETE > in the result dump. Therefore, any change in the set of specific privile= ges will lead to > a non-zero dumps diff. > To avoid this, i propose to replace any specific GRANT and REVOKE in the= result dumps with ALL. > This also made in the patch attached. Isn't that likely to mask actual bugs? regards, tom lane