Message-ID: <81ce3e64469db60b2b79173aca8a54b6cc2680b8.camel@j-davis.com>
Subject: Re: Improve WALRead() to suck data directly from WAL buffers when
 possible
From: Jeff Davis <pgsql@j-davis.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Dilip Kumar <dilipbalaut@gmail.com>,
  Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org, Nathan Bossart
 <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: Sat, 04 Nov 2023 14:27:39 -0700
In-Reply-To: <CALj2ACUq9QP3LgARP1iiehazRZHDatc=rcBXOXv48M0cmHNDCw@mail.gmail.com>
References: 
	<CALj2ACXKKK=wbiG5_t6dGao5GoecMwRkhr7GjVBM_jg54+Na=Q@mail.gmail.com>
	 <20221212.115717.1183698540772933396.horikyota.ntt@gmail.com>
	 <CALj2ACXUbvON86vgwTkum8ab3bf1=HkMxQ5hZJZS3ZcJn8NEXQ@mail.gmail.com>
	 <CAFiTN-uCG-+axA4r02_9OYgKJU_GkJ1=tBCxq_5UvyWmWEBywA@mail.gmail.com>
	 <CALj2ACU9cfAcfVsGwUqXMace_7rfSBJ7+hXVJfVV1jnspTDGHQ@mail.gmail.com>
	 <628b07b79743e2614ab1724f516cbd41560d6551.camel@j-davis.com>
	 <20230114203403.4zpg72fw2qb34awf@awork3.anarazel.de>
	 <0d84c025e38673cb575dcf4987d050fe7b1e1a1f.camel@j-davis.com>
	 <20231011224353.cl7c2s222dw3de4j@awork3.anarazel.de>
	 <CALj2ACU2DGH-BB_187N7gfVkLdxfJ+doVTcteS0ugLn_c8mLOw@mail.gmail.com>
	 <CALj2ACVgVgA5BSSrEYO2eTMEGB=QUbcYosYm3vZ3R2=GPB6tNw@mail.gmail.com>
	 <5c6e8e60c5c156a9f51ccf850f70829e45a985a1.camel@j-davis.com>
	 <CALj2ACVjzHgQvONnTLffyBJRACPwhsf-cYG4TQ2KHKrFfFop-w@mail.gmail.com>
	 <4132fe48f831ed6f73a9eb191af5fe475384969c.camel@j-davis.com>
	 <CALj2ACV123Ke6wn05QCnCgJhFpcarGCv7sKM1p39t+qpUNHUgQ@mail.gmail.com>
	 <2ef04861c0f77e7ae78b703770cc2bbbac3d85e6.camel@j-davis.com>
	 <CALj2ACUXN42H=_Jzw4oYZxoW0gyx82gALJ7vicz9UOuLVRbjnw@mail.gmail.com>
	 <c3455ab9da42e09ca9d059879b5c512b2d1f9681.camel@j-davis.com>
	 <CALj2ACUq9QP3LgARP1iiehazRZHDatc=rcBXOXv48M0cmHNDCw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/81ce3e64469db60b2b79173aca8a54b6cc2680b8.camel%40j-davis.com>
Precedence: bulk

On Sat, 2023-11-04 at 20:55 +0530, Bharath Rupireddy wrote:
> +		XLogRecPtr	EndPtr =3D
> pg_atomic_read_u64(&XLogCtl->xlblocks[curridx]);
> +
> +		/*
> +		 * xlblocks value can be InvalidXLogRecPtr before
> the new WAL buffer
> +		 * page gets initialized in AdvanceXLInsertBuffer.
> In such a case
> +		 * re-read the xlblocks value under the lock to
> ensure the correct
> +		 * value is read.
> +		 */
> +		if (unlikely(XLogRecPtrIsInvalid(EndPtr)))
> +		{
> +			LWLockAcquire(WALBufMappingLock,
> LW_EXCLUSIVE);
> +			EndPtr =3D pg_atomic_read_u64(&XLogCtl-
> >xlblocks[curridx]);
> +			LWLockRelease(WALBufMappingLock);
> +		}
> +
> +		Assert(!XLogRecPtrIsInvalid(EndPtr));

Can that really happen? If the EndPtr is invalid, that means the page
is in the process of being cleared, so the contents of the page are
undefined at that time, right?

Regards,
	Jeff Davis