Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cK4oE-0003Z2-1C for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Dec 2016 14:57:30 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cK4oD-0002Uf-FR for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Dec 2016 14:57:29 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cK4mn-0000tP-Pp for pgsql-hackers@postgresql.org; Thu, 22 Dec 2016 14:56:01 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cK4mk-0006Ii-Nw for pgsql-hackers@postgresql.org; Thu, 22 Dec 2016 14:56:00 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id uBMEtt9P008204; Thu, 22 Dec 2016 09:55:55 -0500 From: Tom Lane To: Joe Conway cc: pgsql-hackers@postgresql.org Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw In-reply-to: References: <19872.1482338965@sss.pgh.pa.us> <21630.1482341251@sss.pgh.pa.us> <1312.1482343733@sss.pgh.pa.us> <02fa2d90-2efd-00bc-fefc-c23c00eb671e@joeconway.com> <19852.1482366129@sss.pgh.pa.us> <3f3f5c79-acb3-5b4b-0e69-9563b9722b84@joeconway.com> <12123.1482384030@sss.pgh.pa.us> Comments: In-reply-to Joe Conway message dated "Wed, 21 Dec 2016 22:04:51 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8202.1482418555.1@sss.pgh.pa.us> Date: Thu, 22 Dec 2016 09:55:55 -0500 Message-ID: <8203.1482418555@sss.pgh.pa.us> X-Pg-Spam-Score: -5.0 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Joe Conway writes: > On 12/21/2016 09:20 PM, Tom Lane wrote: >> I see that you need to pass the PGconn into dblink_res_error() now, but >> what's the point of the new "bool fail" parameter? > That part isn't new -- we added it sometime prior to 9.2: Oh! I misread the patch --- something about an unluckily-placed line wrap and not looking very closely :-(. Yeah, it's fine as is. Sorry for the noise. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers