From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
        vignesh C <vignesh21@gmail.com>, Andres Freund <andres@anarazel.de>,
        Melanie Plageman <melanieplageman@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Peter Smith <smithpb2250@gmail.com>
Subject: Re: Relation bulk write facility
In-reply-to: <8a5a2f85-9a75-4d2d-9c75-0608ee98886b@iki.fi>
References: <30e8f366-58b3-b239-c521-422122dd5150@iki.fi> <c8bbc68e-1e5f-4d62-9c3a-7513f4b3ce72@iki.fi> <20231119000416.fuyrbo6av7dytmf6@awork3.anarazel.de> <93e91b02-e07f-4205-8de6-3942b91760cb@iki.fi> <CALDaNm0WYTR4mnvb8nRCWBinFw1kP9x0aSqmdswHj_Nr50YQug@mail.gmail.com> <98832b4f-441f-4691-b9d4-9725eea8aed9@iki.fi> <CAHut+Pt3WatNznD8q4wmm1GSR7vAHLNBmHERAmguH9N9LCBx1Q@mail.gmail.com> <6db39a5e-67ab-495d-9dfb-38b596df0d58@iki.fi> <a9708f51-e8db-44d7-b522-a90e0b0e40e1@iki.fi> <9e1f63c3-ef16-404c-b3cb-859a96eaba39@iki.fi> <814466.1708701344@sss.pgh.pa.us> <8a5a2f85-9a75-4d2d-9c75-0608ee98886b@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Fri, 23 Feb 2024 17:43:28 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <820443.1708704361.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 23 Feb 2024 11:06:01 -0500
Message-ID: <820444.1708704361@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/820444.1708704361%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Thanks, the error message was clear enough:
>> bulk_write.c:78:3: error: redefinition of typedef 'BulkWriteState' is a=
 C11 feature [-Werror,-Wtypedef-redefinition]
>> } BulkWriteState;

> Fixed now, but I'm a bit surprised other buildfarm members nor cirrus CI=
 =

> caught that. I also tried to reproduce it locally by adding =

> -Wtypedef-redefinition, but my version of clang didn't produce any =

> warnings. Are there any extra compiler options on those animals or =

> something?

They use Apple's standard compiler (clang 15 or so), but

     'CC' =3D> 'ccache clang -std=3Dgnu99',

so maybe the -std has something to do with it.  I installed that
(or -std=3Dgnu90 as appropriate to branch) on most of my build
setups back when we started the C99 push.

			regards, tom lane