MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Tue, 06 Apr 2021 10:57:01 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Zhihong Yu <zyu@yugabyte.com>, Kyotaro Horiguchi
 <horikyota.ntt@gmail.com>, PostgreSQL-development
 <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>,
 gkokolatos@protonmail.com, kasahara.tatsuhito@gmail.com, Craig Ringer
 <craig@2ndquadrant.com>
Subject: Re: Get memory contexts of an arbitrary backend process
In-Reply-To: <c899e0d4-ac82-1f4e-bbd3-41c40b33f0e9@oss.nttdata.com>
References: <bbecd722d4f8e261b350186ac4bf68a7@oss.nttdata.com>
 <1f259e90-08c8-2202-be66-f7ee05d22cd2@oss.nttdata.com>
 <f6f6373ae200c8a0e7466e4de9ca65eb@oss.nttdata.com>
 <20210331.151612.259240960686480846.horikyota.ntt@gmail.com>
 <65fbf059-bcff-1585-59a1-1ec6a6f5ac75@oss.nttdata.com>
 <e1fdbdcae9fac88cf4cd4b552bc4a741@oss.nttdata.com>
 <CALNJ-vQ=x-9AgsVA5fQH_LZQABr+G3ATCPoWE-WFmwjd9Lhp3w@mail.gmail.com>
 <6ab7b7f1-8dca-288f-5578-0a0716567341@oss.nttdata.com>
 <bd216370d915116da8c3cba6537f78dc@oss.nttdata.com>
 <c899e0d4-ac82-1f4e-bbd3-41c40b33f0e9@oss.nttdata.com>
Message-ID: <8205c0edb46ae848bcf07635ac2cc7ee@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.1.9
Archived-At: 
 <https://www.postgresql.org/message-id/8205c0edb46ae848bcf07635ac2cc7ee%40oss.nttdata.com>
Precedence: bulk

On 2021-04-06 00:08, Fujii Masao wrote:
> On 2021/04/05 21:03, torikoshia wrote:
>> On 2021-04-05 12:59, Fujii Masao wrote:
>>> On 2021/04/05 12:20, Zhihong Yu wrote:
>> 
>> Thanks for reviewing!
>> 
>>>> + * On receipt of this signal, a backend sets the flag in the signal
>>>> + * handler, and then which causes the next CHECK_FOR_INTERRUPTS()
>> 
>>>> I think the 'and then' is not needed:
>> 
>> Although I wonder either would be fine, removed the words.
>> 
>>>> +        * This is just a warning so a loop-through-resultset will 
>>>> not abort
>>>> +        * if one backend logged its memory contexts during the run.
>>>> 
>>>> The pid given by arg 0 is not a PostgreSQL server process. Which 
>>>> other backend could it be ?
>>> 
>>> This is the comment that I added wrongly. So the comment should be
>>> "This is just a warning so a loop-through-resultset will not abort
>>> if one backend terminated on its own during the run.",
>>> like pg_signal_backend(). Thought?
>> 
>> +1.
>> 
>> Attached v10 patch.
> 
> Thanks for updating the patch!
> 
> I updated the patch as follows. Could you check the attached patch?

Thanks a lot!

I don't have any objections to your improvements.

Regards,