Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tmWFE-007Hu0-Pw for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Feb 2025 11:03:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tmWFD-00182V-P4 for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Feb 2025 11:03:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tmWFD-001829-Cz for pgsql-hackers@lists.postgresql.org; Mon, 24 Feb 2025 11:03:27 +0000 Received: from forward501b.mail.yandex.net ([178.154.239.145]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tmWF8-000Sdi-1m for pgsql-hackers@lists.postgresql.org; Mon, 24 Feb 2025 11:03:26 +0000 Received: from mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net [IPv6:2a02:6b8:c08:e9ba:0:640:977c:0]) by forward501b.mail.yandex.net (Yandex) with ESMTPS id 92DC1610E6; Mon, 24 Feb 2025 14:03:19 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id D3ZkZs1Lka60-LCx98iHc; Mon, 24 Feb 2025 14:03:18 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tantorlabs.com; s=mail; t=1740394999; bh=WRYAvXYjwh8qmm90+vloIoxQ7y/oEyF5R4RFghM8I68=; h=In-Reply-To:Cc:Date:References:To:Subject:Message-ID:From; b=TPkJsIxDJExcFFFQ39IKB5XDIAloHVv6sx5z5h+hPhedxY2GGvgSMgv79SD4h/Si8 RPc9JSnGR5N9gza9e5bkFOfW8BYaSE18UIJBhviIw6r+hGN9iAo3FqJ9qhMw73NXyO 1A8lBP2KebC2bAvTxn1Ofe56+B3sK8Xc/Gd1ud3M= Authentication-Results: mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net; dkim=pass header.i=@tantorlabs.com Content-Type: multipart/mixed; boundary="------------Y0voC1SE57HOFTHi2q0FPLnb" Message-ID: <821872a3-6f3e-4efc-afe8-540b83be40ff@tantorlabs.com> Date: Mon, 24 Feb 2025 14:03:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: explain analyze rows=%.0f To: Robert Haas Cc: Andrei Lepikhov , pgsql-hackers@lists.postgresql.org, Tom Lane , Matheus Alcantara , Guillaume Lelarge , Daniel Gustafsson , Ibrar Ahmed , "Gregory Stark (as CFM)" , Amit Kapila , Justin Pryzby , Peter Geoghegan , vignesh C , "David G. Johnston" , Alena Rybakina References: <3212947.1739306803@sss.pgh.pa.us> <3365160.1739385615@sss.pgh.pa.us> <0e4c813a-18eb-41e2-8edb-89b78d43c82d@gmail.com> <01ec86c1-e04b-4cbe-b641-22cae8b87604@tantorlabs.com> <73e2440e-7d8b-4860-974d-931a93326d95@gmail.com> <7ab512ac-eed1-4fc8-9c5f-b42c0b0d313e@tantorlabs.com> Content-Language: en-US From: Ilia Evdokimov In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------Y0voC1SE57HOFTHi2q0FPLnb Content-Type: multipart/alternative; boundary="------------ApwHQq71qePU3nTpmq0gwZJ6" --------------ApwHQq71qePU3nTpmq0gwZJ6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 22.02.2025 00:20, Robert Haas wrote: > So, I've committed v11-0001. I'm not altogether convinced that > v11-0002 is necessary -- no portion of the documentation that it > modifies is falsified by the committed patch. Maybe we can just call > this one done for now and move on? Not quite. If no one objects to leaving the documentation as it is, there is one nuance that needs to be fixed—in example [0], there is a node with loops=10, so it should be updated to reflect the current state. I've attached a patch for that. --------------ApwHQq71qePU3nTpmq0gwZJ6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 22.02.2025 00:20, Robert Haas wrote:
So, I've committed v11-0001. I'm not altogether convinced that
v11-0002 is necessary -- no portion of the documentation that it
modifies is falsified by the committed patch. Maybe we can just call
this one done for now and move on?


Not quite. If no one objects to leaving the documentation as it is, there is one nuance that needs to be fixed—in example [0], there is a node with loops=10, so it should be updated to reflect the current state. I've attached a patch for that.

--------------ApwHQq71qePU3nTpmq0gwZJ6-- --------------Y0voC1SE57HOFTHi2q0FPLnb Content-Type: text/x-patch; charset=UTF-8; name="v12-0001-Update-documentation-after-changing-the-rows-format.patch" Content-Disposition: attachment; filename*0="v12-0001-Update-documentation-after-changing-the-rows-format"; filename*1=".patch" Content-Transfer-Encoding: base64 RnJvbSBjMTdjMTkyNjU5OGZiYjM1YTgyOWE5OGVhMzVkYjNjNDFmMWM3Y2NjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBJbGlhIEV2ZG9raW1vdiA8aWx5YS5ldmRva2ltb3ZA dGFudG9ybGFicy5jb20+CkRhdGU6IE1vbiwgMjQgRmViIDIwMjUgMTM6NTU6MTUgKzAzMDAK U3ViamVjdDogW1BBVENIIHYxMl0gVXBkYXRlIGRvY3VtZW50YXRpb24gYWZ0ZXIgY2hhbmdp bmcgdGhlIHJvd3MgZm9ybWF0IGluCiBFWFBMQUlOIEFOQUxZWkUKCkZvbGxvd2luZyBjb21t aXQgZGRiMTdlMywgdGhlIGZvcm1hdCBvZiB0aGUgYXZlcmFnZSByb3dzIiBmaWVsZAppbiBF WFBMQUlOIEFOQUxZWkUgd2FzIG1vZGlmaWVkIHRvIGFsd2F5cyBkaXNwbGF5IGZyYWN0aW9u YWwgdmFsdWVzCndoZW4gbG9vcHMgPiAxLiBUaGlzIGNvbW1pdCB1cGRhdGVzIHRoZSBleGFt cGxlIGluIHRoZSBkb2N1bWVudGF0aW9uCnRvIHJlZmxlY3QgdGhlIG5ldyBvdXRwdXQgZm9y bWF0LCBlbnN1cmluZyBjb25zaXN0ZW5jeSB3aXRoIHRoZSBsYXRlc3QgYmVoYXZpb3IuCi0t LQogZG9jL3NyYy9zZ21sL3BlcmZvcm0uc2dtbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dt bC9wZXJmb3JtLnNnbWwgYi9kb2Mvc3JjL3NnbWwvcGVyZm9ybS5zZ21sCmluZGV4IGE1MDJh MmFhYmEuLjZhM2RjYzBiZmMgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9wZXJmb3JtLnNn bWwKKysrIGIvZG9jL3NyYy9zZ21sL3BlcmZvcm0uc2dtbApAQCAtNzMwLDcgKzczMCw3IEBA IFdIRVJFIHQxLnVuaXF1ZTEgJmx0OyAxMCBBTkQgdDEudW5pcXVlMiA9IHQyLnVuaXF1ZTI7 CiAgICAgICAgICAtJmd0OyAgQml0bWFwIEluZGV4IFNjYW4gb24gdGVuazFfdW5pcXVlMSAg KGNvc3Q9MC4wMC4uNC4zNiByb3dzPTEwIHdpZHRoPTApIChhY3R1YWwgdGltZT0wLjAwNC4u MC4wMDQgcm93cz0xMCBsb29wcz0xKQogICAgICAgICAgICAgICAgSW5kZXggQ29uZDogKHVu aXF1ZTEgJmx0OyAxMCkKICAgICAgICAgICAgICAgIEJ1ZmZlcnM6IHNoYXJlZCBoaXQ9Mgot ICAgLSZndDsgIEluZGV4IFNjYW4gdXNpbmcgdGVuazJfdW5pcXVlMiBvbiB0ZW5rMiB0MiAg KGNvc3Q9MC4yOS4uNy45MCByb3dzPTEgd2lkdGg9MjQ0KSAoYWN0dWFsIHRpbWU9MC4wMDMu LjAuMDAzIHJvd3M9MSBsb29wcz0xMCkKKyAgIC0mZ3Q7ICBJbmRleCBTY2FuIHVzaW5nIHRl bmsyX3VuaXF1ZTIgb24gdGVuazIgdDIgIChjb3N0PTAuMjkuLjcuOTAgcm93cz0xIHdpZHRo PTI0NCkgKGFjdHVhbCB0aW1lPTAuMDAzLi4wLjAwMyByb3dzPTEuMDAgbG9vcHM9MTApCiAg ICAgICAgICBJbmRleCBDb25kOiAodW5pcXVlMiA9IHQxLnVuaXF1ZTIpCiAgICAgICAgICBC dWZmZXJzOiBzaGFyZWQgaGl0PTI0IHJlYWQ9NgogIFBsYW5uaW5nOgotLSAKMi4zNC4xCgo= --------------Y0voC1SE57HOFTHi2q0FPLnb--