Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Sergei Kornilov <sk@zsrv.org>,
 "imai.yoshikazu@fujitsu.com" <imai.yoshikazu@fujitsu.com>,
 legrand legrand <legrand_legrand@hotmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <20200316214912.iakenhp7vyd37hmg@nol>
 <6300601584711975@vla4-87a00c2d2b1b.qloud-c.yandex.net>
 <20200320193004.rqgf3iim4fugq3sm@nol>
 <bdfee4e0-a304-2498-8da5-3cb52c0a193e@oss.nttdata.com>
 <20200325134553.GA14054@nol>
 <c20a2e2f-527d-cffd-a2c7-dde2bee23b3f@oss.nttdata.com>
 <20200326132242.GA80836@nol> <20200327100001.qarktrnxldmoxzgd@nol>
 <807c7d80-c748-3e86-d6e7-cfa01184ee92@oss.nttdata.com>
 <CAOBaU_b3-YYooA5swR+=t5QzjFRnWhxNuZWhNtYb=dwQWq__FQ@mail.gmail.com>
 <20200329061549.smtokn3ip5pqldia@nol>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <8224bfdf-dcf8-648f-e0d8-1db1d5c215ee@oss.nttdata.com>
Date: Mon, 30 Mar 2020 13:56:43 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200329061549.smtokn3ip5pqldia@nol>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/03/29 15:15, Julien Rouhaud wrote:
> On Fri, Mar 27, 2020 at 03:42:50PM +0100, Julien Rouhaud wrote:
>> On Fri, Mar 27, 2020 at 2:01 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>>
>>
>>> So what I'd like to say is that the information that users are interested
>>> in would vary on each situation and case. At least for me it seems
>>> enough for pgss to report only the basic information. Then users
>>> can calculate to get the numbers (like total_time) they're interested in,
>>> from those basic information.
>>>
>>> But of course, I'd like to hear more opinions about this...
>>
>> +1
>>
>> Unless someone chime in by tomorrow, I'll just drop the sum as it
>> seems less controversial and not a blocker in userland if users are
>> interested.
> 
> Done in attached v11, with also the s/querytext/query_text/ discrepancy noted
> previously.

Thanks for updating the patch! But I still think query_string is better
name because it's used in other several places, for the sake of consistency.
So I changed the argument name that way and commit the 0001 patch.
If you think query_text is better, let's keep discussing this topic!

Anyway many thanks for your great job!

>>>> I also exported BufferUsageAccumDiff as mentioned previously, as it seems
>>>> clearner and will avoid future useless code churn, and run pgindent.
>>>
>>> Many thanks!! I'm thinking to commit this part separately.
>>> So I made that patch based on your patch. Attached.
>>
>> Thanks! It looks good to me.
> 
> I also kept that part in a distinct commit for convenience.

I also pushed 0002 patch. Thanks!

I will review 0003 patch again.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters