Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHRCq-0006CR-1T for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Jul 2023 15:47:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qHRCo-0001Gh-W7 for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Jul 2023 15:47:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHRCo-0001GR-Im for pgsql-hackers@lists.postgresql.org; Thu, 06 Jul 2023 15:47:42 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qHRCl-002NeQ-5C for pgsql-hackers@postgresql.org; Thu, 06 Jul 2023 15:47:41 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 87F5F60008; Thu, 6 Jul 2023 15:47:34 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------HGmD7HYqN9nw8Qceq1hy4omo" Message-ID: <825ec386-bce4-a280-3d39-47b049d640c7@dunslane.net> Date: Thu, 6 Jul 2023 11:47:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: pgindent vs. pgperltidy command-line arguments Content-Language: en-US From: Andrew Dunstan To: Peter Eisentraut , Tom Lane Cc: pgsql-hackers References: <45aacd8a-5265-d9da-8df2-b8e2c0cf6a07@eisentraut.org> <1471230.1685020832@sss.pgh.pa.us> In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------HGmD7HYqN9nw8Qceq1hy4omo Content-Type: multipart/alternative; boundary="------------d3z0eVJTSHYdeVlT8BhRvLV7" --------------d3z0eVJTSHYdeVlT8BhRvLV7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-06-21 We 07:35, Andrew Dunstan wrote: > > > On 2023-06-21 We 05:09, Peter Eisentraut wrote: >> On 20.06.23 17:38, Andrew Dunstan wrote: >>>>> +1, although I wonder if we shouldn't follow pgindent's new lead >>>>> and require some argument(s). >>>> >>>> That makes sense to me.  Here is a small update with this behavior >>>> change and associated documentation update. >>> >>> I'm intending to add some of the new pgindent features to >>> pgperltidy. Preparatory to that here's a rewrite of pgperltidy in >>> perl - no new features yet but it does remove the hardcoded path, >>> and requires you to pass in one or more files / directories as >>> arguments. >> >> Are you planning to touch pgperlcritic and pgperlsyncheck as well? > > > Yeah, it would make sense to. > Here's a patch that turns all these into perl scripts. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------d3z0eVJTSHYdeVlT8BhRvLV7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 2023-06-21 We 07:35, Andrew Dunstan wrote:


On 2023-06-21 We 05:09, Peter Eisentraut wrote:
On 20.06.23 17:38, Andrew Dunstan wrote:
+1, although I wonder if we shouldn't follow pgindent's new lead
and require some argument(s).

That makes sense to me.  Here is a small update with this behavior change and associated documentation update.

I'm intending to add some of the new pgindent features to pgperltidy. Preparatory to that here's a rewrite of pgperltidy in perl - no new features yet but it does remove the hardcoded path, and requires you to pass in one or more files / directories as arguments.

Are you planning to touch pgperlcritic and pgperlsyncheck as well? 


Yeah, it would make sense to.



Here's a patch that turns all these into perl scripts.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------d3z0eVJTSHYdeVlT8BhRvLV7-- --------------HGmD7HYqN9nw8Qceq1hy4omo Content-Type: text/x-patch; charset=UTF-8; name="perl-check-scripts-perl.patch" Content-Disposition: attachment; filename="perl-check-scripts-perl.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy90b29scy9wZXJsY2hlY2svRmluZFBlcmxGaWxlcy5wbSBiL3Ny Yy90b29scy9wZXJsY2hlY2svRmluZFBlcmxGaWxlcy5wbQpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwLi4zYTA5OGY2NjE0Ci0tLSAvZGV2L251bGwKKysrIGIvc3Jj L3Rvb2xzL3BlcmxjaGVjay9GaW5kUGVybEZpbGVzLnBtCkBAIC0wLDAgKzEsNjIgQEAKKwor IyBDb3B5cmlnaHQgKGMpIDIwMjMsIFBvc3RncmVTUUwgR2xvYmFsIERldmVsb3BtZW50IEdy b3VwCisKKz1wb2QKKworPWhlYWQxIE5BTUUKKworRmluZFBlcmxGaWxlcyAtIG1vZHVsZSBm b3IgZmluZGluZyBwZXJsIGZpbGVzIGZyb20gYSBsaXN0IG9mIHBhdGhzCisKKz1oZWFkMSBT WU5PUFNJUworCisgIHVzZSBGaW5kUGVybEZpbGVzOworCisgIG15IEBmaWxlcyA9IEZpbmRQ ZXJsRmlsZXM6OmZpbmRwZXJsKHBhdGgsIC4uLik7CisKKworPWhlYWQxIERFU0NSSVBUSU9O CisKK0ZpbmRQZXJsRmlsZXMgZmluZHMgZmlsZXMgd2hpY2ggZWl0aGVyIGhhdmUgYSBwZXJs IGV4dGVuc2lvbiAoLnBsIG9yIC5wbSkgb3IKK2FyZSBib3QgZXhlY3V0YWJsZSBhbmQgZm91 bmQgYnkgdGhlIGBmaWxlYCBwcm9ncmFtIHRvIGJlIHBlcmwgc2NyaXB0cy4KKworPWN1dAor CisKK3BhY2thZ2UgRmluZFBlcmxGaWxlczsKKwordXNlIHN0cmljdDsKK3VzZSB3YXJuaW5n czsKKwordXNlIEZpbGU6OkZpbmQ7Cit1c2UgRmlsZTo6c3RhdDsKK3VzZSBGY250bCAnOm1v ZGUnOworCitteSBAZmlsZXM7CisKK3N1YiBfaXNfcGVybF9leGVjCit7CisJbXkgJG5hbWUg PSBzaGlmdDsKKwlteSAkb3V0ID0gYGZpbGUgJG5hbWUgMj4vZGV2L251bGxgOworCXJldHVy biAkb3V0ID1+IC86LipwZXJsWzAtOV0qXGIvaTsKK30KKworc3ViIGZpbmRwZXJsCit7CisJ bXkgQGZpbGVzIDsKKwlteSAkd2FudGVkID0gc3ViCisJeworCQlteSAkbmFtZSA9ICRGaWxl OjpGaW5kOjpuYW1lOworCQlteSAkc3Q7CisJCSMgY2hlY2sgaXQncyBhIHBsYWluIGZpbGUg YW5kIGVpdGhlciBpdCBoYXMgYSBwZXJsIGV4dGVuc2lvbiAoLnBbbG1dKQorCQkjIG9yIGl0 J3MgZXhlY3V0YWJsZSBhbmQgYGZpbGVgIHRoaW5rcyBpdCdzIGEgcGVybCBzY3JpcHQuCisJ CSgkc3QgPSBsc3RhdCgkXykpCisJCSAgJiYgLWYgJHN0CisJCSAgJiYgKC9cLnBbbG1dJC8g fHwgKCgoJHN0LT5tb2RlICYgU19JWFVTUikgJiYgX2lzX3BlcmxfZXhlYygkXykpKSkKKwkJ ICAmJiBwdXNoKEBmaWxlcywgJG5hbWUpOworCX07CisKKwlGaWxlOjpGaW5kOjpmaW5kKHsg d2FudGVkID0+ICR3YW50ZWQgfSwgQF8pOworCXJldHVybiBAZmlsZXM7Cit9CisKKzE7CmRp ZmYgLS1naXQgYS9zcmMvdG9vbHMvcGVybGNoZWNrL2ZpbmRfcGVybF9maWxlcyBiL3NyYy90 b29scy9wZXJsY2hlY2svZmluZF9wZXJsX2ZpbGVzCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAyMGRjZWI4MDBkLi4wMDAwMDAwMDAwCi0tLSBhL3NyYy90b29scy9wZXJsY2hl Y2svZmluZF9wZXJsX2ZpbGVzCisrKyAvZGV2L251bGwKQEAgLTEsMTggKzAsMCBAQAotIyBz cmMvdG9vbHMvcGVybGNoZWNrL2ZpbmRfcGVybF9maWxlcwotCi0jIHNoZWxsIGZ1bmN0aW9u IHRvIGZpbmQgYWxsIHBlcmwgZmlsZXMgaW4gdGhlIHNvdXJjZSB0cmVlCi0KLWZpbmRfcGVy bF9maWxlcyAoKSB7Ci0JaWYgWyAkIyAtZXEgMCBdOyB0aGVuCi0JCWVjaG8gJ05vIGZpbGVz IHRvIHByb2Nlc3MnIDE+JjIKLQkJcmV0dXJuCi0JZmkKLSAgICB7Ci0JCSMgdGFrZSBhbGwg LnBsIGFuZCAucG0gZmlsZXMKLQkJZmluZCAiJEAiIC10eXBlIGYgLW5hbWUgJyoucFtsbV0n IC1wcmludAotCQkjIHRha2UgZXhlY3V0YWJsZSBmaWxlcyB0aGF0IGZpbGUoMSkgdGhpbmtz IGFyZSBwZXJsIGZpbGVzCi0JCWZpbmQgIiRAIiAtdHlwZSBmIC1wZXJtIC0xMDAgLWV4ZWMg ZmlsZSB7fSBcOyAtcHJpbnQgfAotCQllZ3JlcCAtaSAnOi4qcGVybFswLTldKlw+JyB8Ci0J CWN1dCAtZDogLWYxCi0JfSB8IHNvcnQgLXUgfCBncmVwIC12ICdeXC4vXC5naXQvJwotfQpk aWZmIC0tZ2l0IGEvc3JjL3Rvb2xzL3BlcmxjaGVjay9wZ3Blcmxjcml0aWMgYi9zcmMvdG9v bHMvcGVybGNoZWNrL3BncGVybGNyaXRpYwppbmRleCAyZWM2ZjIwZGUzLi44N2Q1ZTkyZGY3 IDEwMDc1NQotLS0gYS9zcmMvdG9vbHMvcGVybGNoZWNrL3BncGVybGNyaXRpYworKysgYi9z cmMvdG9vbHMvcGVybGNoZWNrL3BncGVybGNyaXRpYwpAQCAtMSwyMCArMSwyNyBAQAotIyEv YmluL3NoCisjIS91c3IvYmluL3BlcmwKKworIyBDb3B5cmlnaHQgKGMpIDIwMjMsIFBvc3Rn cmVTUUwgR2xvYmFsIERldmVsb3BtZW50IEdyb3VwCiAKICMgc3JjL3Rvb2xzL3BlcmxjaGVj ay9wZ3Blcmxjcml0aWMKIAotdGVzdCAtZiBzcmMvdG9vbHMvcGVybGNoZWNrL3Blcmxjcml0 aWNyYyB8fCB7Ci0JZWNobyBjb3VsZCBub3QgZmluZCBzcmMvdG9vbHMvcGVybGNoZWNrL3Bl cmxjcml0aWNyYwotCWV4aXQgMQotCX0KK3VzZSBzdHJpY3Q7Cit1c2Ugd2FybmluZ3M7CiAK LXNldCAtZQordXNlIEZpbmRCaW4gKCk7Cit1c2UgbGliICIkRmluZEJpbjo6QmluIjsKK3Vz ZSBGaW5kUGVybEZpbGVzOworCitkaWUgIk5vIGRpcmVjdG9yaWVzIG9yIGZpbGVzIHNwZWNp ZmllZFxuIiB1bmxlc3MgQEFSR1Y7CisKK215ICRyY19sb2MgPSAiJEZpbmRCaW46OkJpbi9w ZXJsY3JpdGljcmMiOworCitkaWUgIm5vICRyY19sb2NcbiIgdW5sZXNzIC1mICRyY19sb2M7 CiAKICMgc2V0IHRoaXMgdG8gb3ZlcnJpZGUgZGVmYXVsdCBwZXJsY3JpdGljIHByb2dyYW06 Ci1QRVJMQ1JJVElDPSR7UEVSTENSSVRJQzotcGVybGNyaXRpY30KK215ICRwZXJsY3JpdGlj ID0gJEVOVntQRVJMQ1JJVElDfSB8fCAncGVybGNyaXRpYyc7CiAKLS4gc3JjL3Rvb2xzL3Bl cmxjaGVjay9maW5kX3BlcmxfZmlsZXMKK215IEBmaWxlcyA9IEZpbmRQZXJsRmlsZXM6OmZp bmRwZXJsKEBBUkdWKTsKIAotZmluZF9wZXJsX2ZpbGVzICIkQCIgfCB4YXJncyAkUEVSTENS SVRJQyBcCi0JICAtLXF1aWV0IFwKLQkgIC0tcHJvZ3JhbS1leHRlbnNpb25zIC5wbCBcCi0J ICAtLXByb2ZpbGU9c3JjL3Rvb2xzL3BlcmxjaGVjay9wZXJsY3JpdGljcmMKK2V4aXQgdW5s ZXNzIEBmaWxlczsKKworZXhlYyAkcGVybGNyaXRpYywgJy0tcHJvZ3JhbS1leHRlbnNpb25z JywgICcucGwnLCAiLS1wcm9maWxlPSRyY19sb2MiLCBAZmlsZXMKZGlmZiAtLWdpdCBhL3Ny Yy90b29scy9wZXJsY2hlY2svcGdwZXJsc3luY2hlY2sgYi9zcmMvdG9vbHMvcGVybGNoZWNr L3BncGVybHN5bmNoZWNrCmluZGV4IGRhNTljOTcyN2MuLjcwZmYyNDhkYWYgMTAwNzU1Ci0t LSBhL3NyYy90b29scy9wZXJsY2hlY2svcGdwZXJsc3luY2hlY2sKKysrIGIvc3JjL3Rvb2xz L3BlcmxjaGVjay9wZ3BlcmxzeW5jaGVjawpAQCAtMSwxNiArMSw0OCBAQAotIyEvYmluL3No CisjIS91c3IvYmluL3BlcmwKKworIyBDb3B5cmlnaHQgKGMpIDIwMjMsIFBvc3RncmVTUUwg R2xvYmFsIERldmVsb3BtZW50IEdyb3VwCiAKICMgc2NyaXB0IHRvIGRldGVjdCBjb21waWxl IHRpbWUgZXJyb3JzIGFuZCB3YXJuaW5ncyBpbiBhbGwgcGVybCBmaWxlcwogCi1JTkNMVURF Uz0iLUkgc3JjL3Rvb2xzL21zdmMgLUkgc3JjL3Rvb2xzL21zdmMvZHVtbXlsaWIgLUkgc3Jj L2JhY2tlbmQvY2F0YWxvZyIKLUlOQ0xVREVTPSItSSBzcmMvdGVzdC9wZXJsIC1JIHNyYy9i YWNrZW5kL3V0aWxzL21iL1VuaWNvZGUgJElOQ0xVREVTIgotSU5DTFVERVM9Ii1JIHNyYy9i aW4vcGdfcmV3aW5kIC1JIHNyYy90ZXN0L3NzbC90ICRJTkNMVURFUyIKK3VzZSBzdHJpY3Q7 Cit1c2Ugd2FybmluZ3M7CiAKLXNldCAtZQordXNlIEZpbmRCaW4gKCk7Cit1c2UgbGliICIk RmluZEJpbjo6QmluIjsKIAotLiBzcmMvdG9vbHMvcGVybGNoZWNrL2ZpbmRfcGVybF9maWxl cwordXNlIEN3ZCBxdyhhYnNfcGF0aCk7Cit1c2UgRmluZFBlcmxGaWxlczsKIAotIyBmb3Ig enNoCi1zZXRvcHQgc2h3b3Jkc3BsaXQgMj4vZGV2L251bGwgfHwgdHJ1ZQorZGllICJObyBk aXJlY3RvcmllcyBvciBmaWxlcyBzcGVjaWZpZWRcbiIgdW5sZXNzIEBBUkdWOwogCi1maW5k X3BlcmxfZmlsZXMgIiRAIiB8IHhhcmdzIC1MIDEgcGVybCAkSU5DTFVERVMgLWN3IDI+JjEg fCBncmVwIC12IE9LCitteSAkc3Jjcm9vdCA9IGFic19wYXRoKCIkRmluZEJpbjo6QmluLy4u Ly4uLy4uIik7CisKK215ICRpbmNsdWRlcz0iIjsKKworbXkgQGluY2RpcnMgPSBxdygKKyAg ICBzcmMvdG9vbHMvbXN2YworICAgIHNyYy90b29scy9tc3ZjL2R1bW15bGliCisgICAgc3Jj L2JhY2tlbmQvY2F0YWxvZworICAgIHNyYy90ZXN0L3BlcmwKKyAgICBzcmMvYmFja2VuZC91 dGlscy9tYi9Vbmljb2RlCisgICAgc3JjL2Jpbi9wZ19yZXdpbmQgc3JjL3Rlc3Qvc3NsL3QK Kyk7CisKK2ZvcmVhY2ggbXkgJGluYyAoQGluY2RpcnMpCit7CisgICAgJGluY2x1ZGVzIC49 ICItSSAkc3Jjcm9vdC8kaW5jICI7Cit9CisKK215IEBmaWxlcyA9ICBGaW5kUGVybEZpbGVz OjpmaW5kcGVybChAQVJHVik7CisKK215ICRzdGF0dXMgPSAwOworCitmb3JlYWNoIG15ICRm aWxlIChAZmlsZXMpCit7CisgICAgbXkgJG91dCA9IGBwZXJsICRpbmNsdWRlcyAtY3cgJGZp bGUgMj4mMWA7CisgICAgbmV4dCBpZiAkb3V0ID1+IC9PSy87CisgICAgJHN0YXR1cyA9IDE7 CisgICAgcHJpbnQgJG91dDsKK30KKworZXhpdCAkc3RhdHVzOwpkaWZmIC0tZ2l0IGEvc3Jj L3Rvb2xzL3BnaW5kZW50L3BncGVybHRpZHkgYi9zcmMvdG9vbHMvcGdpbmRlbnQvcGdwZXJs dGlkeQppbmRleCA2YWYyN2QyMWQ1Li5iZTQzM2MxODM2IDEwMDc1NQotLS0gYS9zcmMvdG9v bHMvcGdpbmRlbnQvcGdwZXJsdGlkeQorKysgYi9zcmMvdG9vbHMvcGdpbmRlbnQvcGdwZXJs dGlkeQpAQCAtMSwxMiArMSwyMiBAQAotIyEvYmluL3NoCisjIS91c3IvYmluL3BlcmwKKwor IyBDb3B5cmlnaHQgKGMpIDIwMjMsIFBvc3RncmVTUUwgR2xvYmFsIERldmVsb3BtZW50IEdy b3VwCiAKICMgc3JjL3Rvb2xzL3BnaW5kZW50L3BncGVybHRpZHkKIAotc2V0IC1lCit1c2Ug c3RyaWN0OwordXNlIHdhcm5pbmdzOwogCi0jIHNldCB0aGlzIHRvIG92ZXJyaWRlIGRlZmF1 bHQgcGVybHRpZHkgcHJvZ3JhbToKLVBFUkxUSURZPSR7UEVSTFRJRFk6LXBlcmx0aWR5fQor dXNlIEZpbmRCaW4gKCk7Cit1c2UgbGliICIkRmluZEJpbjo6QmluLy4uL3BlcmxjaGVjayI7 Cit1c2UgRmluZFBlcmxGaWxlczsKIAotLiBzcmMvdG9vbHMvcGVybGNoZWNrL2ZpbmRfcGVy bF9maWxlcworbXkgJHBlcmx0aWR5ID0gJEVOVntQRVJMVElEWX0gfHwgJ3Blcmx0aWR5JzsK IAotZmluZF9wZXJsX2ZpbGVzICIkQCIgfCB4YXJncyAkUEVSTFRJRFkgLS1wcm9maWxlPXNy Yy90b29scy9wZ2luZGVudC9wZXJsdGlkeXJjCitkaWUgIk5vIGRpcmVjdG9yaWVzIG9yIGZp bGVzIHNwZWNpZmllZFxuIiB1bmxlc3MgQEFSR1Y7CisKK215IEBmaWxlcyA9IEZpbmRQZXJs RmlsZXM6OmZpbmRwZXJsKEBBUkdWKTsKKworZXhpdCB1bmxlc3MgQGZpbGVzOworCitleGVj ICIkcGVybHRpZHkiLCAiLS1wcm9maWxlPSRGaW5kQmluOjpCaW4gL3Blcmx0aWR5cmMiLCBA ZmlsZXM7Cg== --------------HGmD7HYqN9nw8Qceq1hy4omo--