Subject: Re: SEARCH and CYCLE clauses
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <db80ceee-6f97-9b4a-8ee8-3ba0c58e5be2@2ndquadrant.com>
 <54e533c5-09e5-7f41-9892-d4e0f7c62598@postgresfriends.org>
 <b267acb8-edc0-31a8-0645-2992d1f0f393@postgresfriends.org>
 <1cfc9079-9595-d167-00e6-5014438cc3e2@2ndquadrant.com>
 <9ce4d370-048c-1d67-fffb-a86f17120132@postgresfriends.org>
 <d9f5c4ff-723a-2eae-2985-02bb11ae5e05@2ndquadrant.com>
 <3c931f0f-6f53-598d-702f-1e6e932690ab@2ndquadrant.com>
From: Vik Fearing <vik@postgresfriends.org>
Message-ID: <82b6e6ca-e138-81a6-673d-20cfbdc4ec3e@postgresfriends.org>
Date: Mon, 22 Feb 2021 11:05:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <3c931f0f-6f53-598d-702f-1e6e932690ab@2ndquadrant.com>
Content-Type: multipart/mixed;
 boundary="------------97A88F3DF50412C693F53E8B"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------97A88F3DF50412C693F53E8B
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

On 2/22/21 9:44 AM, Peter Eisentraut wrote:
> On 22.05.20 14:32, Peter Eisentraut wrote:
>>> As an improvement over the spec, I think the vast majority of people
>>> will be using simple true/false values.  Can we make that optional?
>>>
>>>      CYCLE f, t SET is_cycle USING path
>>>
>>> would be the same as
>>>
>>>      CYCLE f, t SET is_cycle TO true DEFAULT false USING path
>>
>> I was also considering that.  It would be an easy change to make.
> 
> This change has been accepted into the SQL:202x draft.

Yay!

> Here is a patch for it.

This looks good to me, except that you forgot to add the feature stamp.
 Attached is a small diff to apply on top of your patch to fix that.
-- 
Vik Fearing

--------------97A88F3DF50412C693F53E8B
Content-Type: text/x-patch; charset=UTF-8;
 name="sql_features.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="sql_features.diff"

diff --git a/src/backend/catalog/sql_features.txt b/src/backend/catalog/sql_features.txt
index a24387c1e7..1ab5f685b9 100644
--- a/src/backend/catalog/sql_features.txt
+++ b/src/backend/catalog/sql_features.txt
@@ -425,6 +425,7 @@ T121	WITH (excluding RECURSIVE) in query expression			YES
 T122	WITH (excluding RECURSIVE) in subquery			YES	
 T131	Recursive query			YES	
 T132	Recursive query in subquery			YES	
+T133	Enhanced cycle mark values			YES	
 T141	SIMILAR predicate			YES	
 T151	DISTINCT predicate			YES	
 T152	DISTINCT predicate with negation			YES	

--------------97A88F3DF50412C693F53E8B--