Feedback-ID: i131946ab:Fastmail
Message-ID: <82efc9f6-d8d6-7226-b167-b807dce568cd@enterprisedb.com>
Date: Tue, 5 Jul 2022 08:13:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: AIX support - alignment issues
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
 pgsql-hackers@postgresql.org
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
 <20220705053150.tgr5vuiq6olnx7g2@awork3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220705053150.tgr5vuiq6olnx7g2@awork3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/82efc9f6-d8d6-7226-b167-b807dce568cd%40enterprisedb.com>
Precedence: bulk

On 05.07.22 07:31, Andres Freund wrote:
> On 2022-07-02 11:33:54 -0700, Andres Freund wrote:
>> If we decide we want to continue supporting AIX we should bite the bullet and
>> add a 64bit-int TYPALIGN_*. It might be worth to translate that to bytes when
>> building tupledescs, so we don't need more branches (reducing them compared to
>> today).
> 
> I just thought an easier way - why don't we introduce a 'catalog_double'
> that's defined to be pg_attribute_aligned(whatever-we-need) on AIX? Then we
> can get rid of the manually enforced alignedness and we don't need to contort
> catalog order.

Isn't the problem that on AIX, double and int64 have different alignment 
requirements, and we just check the one for double and apply it to 
int64?  That ought to be fixable by two separate alignment checks in 
configure and a new alignment letter for pg_type.