Message-ID: <832093c9-27f3-40fe-88d8-ae416927eacb@pgbackrest.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Improve checks for GUC recovery_target_xid
To: =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Michael Paquier
 <michael@paquier.xyz>, Pg Hackers <pgsql-hackers@postgresql.org>
References: <9e8b7ee9-4a16-477a-baa5-0cdf37a04798@pgbackrest.org>
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
 <c2e97e35-1227-4351-8faa-fa95208f6cf9@pgbackrest.org>
 <aakAmNjKyBWRU1vR@paquier.xyz>
 <e6a27751-8c91-4bff-ba07-2e97de99e34f@pgbackrest.org>
 <CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
 <bc089939-a889-4fd4-bad8-42cc071cd58e@pgbackrest.org>
 <CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com>
 <8733e942-56fc-4542-9351-63f213f7e23c@pgbackrest.org>
 <CAHGQGwEhf9byyjhcDEMAd0kPkTdJsO0-HNTnX6Hqs6puBij3-g@mail.gmail.com>
 <aapxCfGZb3TfzX68@paquier.xyz>
 <CAHGQGwFuXjy7wAkzeDg0cpwsLweyjNO1tACgUWtNdCDtwxZ9hQ@mail.gmail.com>
 <2d228e82-02b5-4e55-a082-1ce26fae5f0f@pgbackrest.org>
 <CAB5wL7Y=BK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg@mail.gmail.com>
Content-Language: en-US
From: David Steele <david@pgbackrest.org>
In-Reply-To: 
 <CAB5wL7Y=BK7jf7J_shotdBqE9cVy4wgZhk1QuFdoeGonDQwaZg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Date: Tue, 17 Mar 2026 14:36:49 +0000 (UTC)
Archived-At: 
 <https://www.postgresql.org/message-id/832093c9-27f3-40fe-88d8-ae416927eacb%40pgbackrest.org>
Precedence: bulk

Hi,

On 3/16/26 14:44, Hüseyin Demir wrote:
> 
> David Steele <david@pgbackrest.org>, 6 Mar 2026 Cum, 16:01 tarihinde şunu yazdı:
>>
>> On 3/6/26 14:05, Fujii Masao wrote:
>>> On Fri, Mar 6, 2026 at 3:15 PM Michael Paquier <michael@paquier.xyz> wrote:
>>>>
>>>> On Fri, Mar 06, 2026 at 12:04:00AM +0900, Fujii Masao wrote:
>>>>> Thanks for the patch! It looks good to me. Barring any objections, I
>>>>> will commit it.
>>>>
>>>> Thanks.
>>>
>>> I've pushed the patch. Thanks!
>>
>> Thank you and great idea on ALTER SYSTEM. I've been hesitant to add more
>> tests in this area because they are so expensive but now I feel much
>> better about it. But that's the last for this CF since there is more
>> important stuff to be done.
>>
>> Regards,
>> -David
> 
> I tried to create tests with the ALTER SYSTEM approach to validate the GUC.
> 
> You can review it if it's the correct approach or not. We can create a
> new CF record if required for the patch.

I modified the tests in the patch to use ALTER SYSTEM and that was 
committed at [1].

One of the tests (bogus) you have added here is a duplicate but the 
other one (upper bound) could be added.

You appear to be working against an old version of the master branch so 
I would recommend rebasing and then add your upper bound test following 
the test pattern we have already established.

I personally don't think the upper bound test adds a lot of value here 
since it is handled by strtou64() just like the bogus test so it will 
not extend coverage, but I'm fine with it if others are.

Regards,
-David

[1] 
https://git.postgresql.org/pg/commitdiff/bffd7130e942e2bd45153ab09e5fab70e74ece58.