Message-ID: <8331c9d408e3e4717c730fde069cec8edd1af356.camel@dalibo.com>
Subject: Re: run pgindent on a regular basis / scripted manner
From: =?ISO-8859-1?Q?=C9tienne?= BERSAC <etienne.bersac@dalibo.com>
To: Andrew Dunstan <andrew@dunslane.net>, Robert Haas
 <robertmhaas@gmail.com>,  Jelte Fennema <postgres@jeltef.nl>
Cc: Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>, Andres
 Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>,
 "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Justin Pryzby
 <pryzby@telsasoft.com>, Noah Misch <noah@leadboat.com>, Bruce Momjian
 <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Alvaro Herrera
 <alvherre@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Jesse Zhang
 <sbjesse@gmail.com>,  "pgsql-hackers@postgresql.org"
 <pgsql-hackers@postgresql.org>, Peter Eisentraut
 <peter.eisentraut@enterprisedb.com>
Date: Fri, 27 Oct 2023 09:14:38 +0200
In-Reply-To: <c2f3b41a-9959-a768-5664-7db390b3718b@dunslane.net>
References: 
	<CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
	 <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de>
	 <CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com>
	 <338202.1691793002@sss.pgh.pa.us>
	 <CAH2-Wz=TNXWQWFgZPehFyPo+9HxxwuHHHYA-ymR+W+kMChM+9Q@mail.gmail.com>
	 <342032.1691794926@sss.pgh.pa.us>
	 <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net>
	 <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de>
	 <530189.1691880417@sss.pgh.pa.us>
	 <CAH2-Wz=OXmLbQ9ykYYSTmadD=fHtn7-ctCqsco7rc2s3Fvx8QQ@mail.gmail.com>
	 <544112.1691886017@sss.pgh.pa.us>
	 <CAH2-WzmueQvoZVScpUcAes3Gq_OGCnOH1RXyMicrMdyaAg6OLA@mail.gmail.com>
	 <CAH2-WznZ4g8mrHCPVr5MBcSFenFnaKPp2K52JvqLt2fjdcR-bg@mail.gmail.com>
	 <2620572.1697503500@sss.pgh.pa.us>
	 <CAH2-WzmhQv=F3oJEvimz2bTFTbXwfJz6eC=1rxSdgRQQYq94nQ@mail.gmail.com>
	 <CAGECzQQL-Dbb+Ykid9Dhq-491MawHvi6hR_NGkhiDE+5zRZ6vQ@mail.gmail.com>
	 <CA+TgmobcCGDhzXS2rnhOeC4VApYYqeKkzzk9usa6NtVBYyMctg@mail.gmail.com>
	 <c2f3b41a-9959-a768-5664-7db390b3718b@dunslane.net>
Organization: DALIBO
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/8331c9d408e3e4717c730fde069cec8edd1af356.camel%40dalibo.com>
Precedence: bulk

Hello,


> Yes, there's a lot to look out for, and you're a damn sight better at
> it=20
> than I am. But we should try to automate the things that can be=20
> automated, even if that leaves many tasks that can't be. I have three
> things in my pre-commit hook: a check for catalog updates, a check
> for=20
> new typedefs, and an indent check.

Could you share your configuration ? Could we provide more helper and
integration to help produce consistent code ?

For logfmt extension, I configured clang-formatd so that Emacs format
the buffer on save. Any editor running clangd will use this. This is
ease my mind about formatting. I need to investigate how to use
pgindent instead or at lease ensure clang-format produce same output as
pgindent.

https://gitlab.com/dalibo/logfmt/-/blob/0d808b368e649b23ac06ce2657354b67be3=
98b21/.clang-format

Automate nitpicking in CI is good, but checking locally before sending
the patch will save way more round-trip.

Regards,
=C3=89tienne