Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: log_min_messages per backend type
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <3d0af6b2-15d1-4f38-9881-df964ba0a89b@app.fastmail.com>
Date: Thu, 11 Dec 2025 10:11:05 +0800
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 japin <japinli@hotmail.com>,
 Andres Freund <andres@anarazel.de>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <83347D77-0FD1-4A16-B026-013E0C9F2A4C@gmail.com>
References: <202512091806.bsugq2l4wz7f@alvherre.pgsql>
 <1130A10B-E7AE-49F3-9E13-2CD69B3F9DFD@gmail.com>
 <3d0af6b2-15d1-4f38-9881-df964ba0a89b@app.fastmail.com>
To: Euler Taveira <euler@eulerto.com>
Archived-At: 
 <https://www.postgresql.org/message-id/83347D77-0FD1-4A16-B026-013E0C9F2A4C%40gmail.com>
Precedence: bulk


> On Dec 11, 2025, at 09:57, Euler Taveira <euler@eulerto.com> wrote:
>=20
>=20
>> In the =E2=80=9Cif=E2=80=9D and =E2=80=9Celse=E2=80=9D clauses, there =
are duplicate code to valid log=20
>> levels. We should refactor the code to avoid the duplication. For=20
>> example, pull up =E2=80=9Cloglevel=E2=80=9D to the =E2=80=9Cfor=E2=80=9D=
 loop level, then we can valid=20
>> it after the =E2=80=9Cif-else=E2=80=9D.
>>=20
>=20
> The for loop is duplicate but if you create a separate function for it =
but the
> result is:
>=20
> src/backend/commands/variable.c | 43 =
++++++++++++++++++++++---------------------
> 1 file changed, 22 insertions(+), 21 deletions(-)
>=20
>=20

I don=E2=80=99t think we need to add a separate function. We can use =
=E2=80=98if-else=E2=80=9D to parse log level, then verify it after =
=E2=80=9Cif-else=E2=80=9D.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/