Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 009FE650286 for ; Thu, 11 Dec 2008 12:30:09 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 23134-03 for ; Thu, 11 Dec 2008 12:30:05 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 3741864FD48 for ; Thu, 11 Dec 2008 12:30:05 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id mBBGTUKq008348; Thu, 11 Dec 2008 11:29:30 -0500 (EST) To: Greg Stark cc: ITAGAKI Takahiro , Gregory Stark , Postgres Subject: Re: posix_fadvise v22 In-reply-to: References: Comments: In-reply-to Greg Stark message dated "Thu, 11 Dec 2008 10:04:13 -0500" Date: Thu, 11 Dec 2008 11:29:30 -0500 Message-ID: <8347.1229012970@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200812/789 X-Sequence-Number: 129418 Greg Stark writes: >> A variable prefetch_pages is defined as "unsigned" or "int" >> in some places. Why don't you define it only once in a header >> and include the header in source files? > Just... Which header? MHO: the header that goes with the source file that is most concerned with implementing the variable's behavior (which is also the file that should have the actual variable definition). regards, tom lane