Subject: Re: suggest to rename enable_incrementalsort
To: James Coleman <jtc331@gmail.com>, Robert Haas <robertmhaas@gmail.com>
References: <df652910-e985-9547-152c-9d4357dc3979@2ndquadrant.com>
 <CAOBaU_bsOKEXgF_ik3bjAfV7HQAM+2MTbAwtKujqiu1YueeUiQ@mail.gmail.com>
 <20200621112159.qtgedtrqw2c47pm4@development>
 <CA+TgmoazhPwebpOwNbHt1vJoos1eLYhJVQPka+pptSLgS685aA@mail.gmail.com>
 <2037457.1592836877@sss.pgh.pa.us> <20200622152219.GC28999@momjian.us>
 <CA+TgmoZB2R-kyT+vO8HU=vxxyN-NGa=fJq9LUT7sASfroQkUUA@mail.gmail.com>
 <CAAaqYe_Pab2-3_kaaPSc1WZZouWAPsKQ4EsDAsdF=coJeB2yqQ@mail.gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
 Tomas Vondra <tomas.vondra@2ndquadrant.com>,
 Julien Rouhaud <rjuju123@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <836dfad2-d15b-36f1-9121-142bd505e090@2ndquadrant.com>
Date: Sun, 5 Jul 2020 12:20:21 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CAAaqYe_Pab2-3_kaaPSc1WZZouWAPsKQ4EsDAsdF=coJeB2yqQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-07-02 17:25, James Coleman wrote:
> I think the change makes a lot of sense. The only reason I had it as
> enable_incrementalsort in the first place was trying to broadly
> following the existing GUC names, but as has already been pointed out,
> there's a lot of variation there, and my version of the patch already
> changed it to be more readable (at one point it was
> enable_incsort...which is short...but does not have an obvious
> meaning).
> 
> I've attached a patch to make the change,

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services