From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in
 targetlist handling)
In-reply-to: <20170117185346.z55d3jnsaf24yr4m@alap3.anarazel.de>
References: <20161031160639.nyxoktszi5psl2cc@alap3.anarazel.de>
 <20170116032952.z2re55hcfhzbkmrm@alap3.anarazel.de>
 <20170116083316.2izqrxbvmyalazac@alap3.anarazel.de>
 <21924.1484593998@sss.pgh.pa.us>
 <CA+TgmoboiMYk1jTL-=2a0iukktCoDnKHMhrQ9za8JrMvkFdYUw@mail.gmail.com>
 <29207.1484675540@sss.pgh.pa.us>
 <20170117180324.dqgz23xaf6wtazb4@alap3.anarazel.de>
 <30268.1484677082@sss.pgh.pa.us>
 <CA+TgmoZm9sARp1Sv8A3Ar7Mf+cKVhHriGt-oFro6VgKocgOUYg@mail.gmail.com>
 <32021.1484678618@sss.pgh.pa.us>
 <20170117185346.z55d3jnsaf24yr4m@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 17 Jan 2017 10:53:46 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <836.1484680521.1@sss.pgh.pa.us>
Date: Tue, 17 Jan 2017 14:15:21 -0500
Message-ID: <837.1484680521@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On 2017-01-17 13:43:38 -0500, Tom Lane wrote:
>> I'm not convinced that that optimization is worth preserving, but if we
>> keep it then ProjectSet isn't le mot juste here, any more than you'd want
>> to rename Result to Project without changing its existing
>> functionality.

> Right. I'd removed that, and re-added it; primarily because the plans
> looked more complex without it. After all, you'd thought it worth adding
> that hack ;)   I'm happy with removing it again too.

Well, it seemed reasonable to do that as long as the only cost was ten or
so lines in create_projection_plan.  But if we're contorting not only the
behavior but the very name of the SRF-evaluation plan node type, that's
not negligible cost anymore.  So now I'm inclined to take it out.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers