Message-ID: <8370d856-28cd-6884-c155-0cbdcc0b4d79@joeconway.com>
Date: Sat, 2 Apr 2022 13:32:22 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>,
 Joshua Brindle <joshua.brindle@crunchydata.com>,
 "Bossart, Nathan" <bossartn@amazon.com>,
 Nathan Bossart <nathandbossart@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>
References: <80af9ba7-ec24-9134-8fd9-00bf13f5c494@joeconway.com>
 <CA+Tgmoa-czkhuLM6ZGKsTTxM56k4Ba2=_2Ai5Uo-u+PSkRVNww@mail.gmail.com>
 <CAGB+Vh5h29oiq=paMPoz_f8rAOhF0AFkAup6Wo2+td=JJ+8Brw@mail.gmail.com>
 <CA+TgmoaGoWYcPX-T0uAheAfrwcvnLUw8N2FsC7TvqQku-qvJUQ@mail.gmail.com>
 <0b1b6cfb-d752-28f6-7ccb-993998be0189@joeconway.com>
 <CA+TgmoYhx2KtBKX6Na-050RS5x5O_=arTzA96VmJd7=6hGBtag@mail.gmail.com>
 <20220209181333.GD1627503@nathanxps13>
 <e2955bbc-f7f4-cb80-d35a-ff754898bab0@joeconway.com>
 <20220210192829.GB1684442@nathanxps13>
 <6135d0b7-3af9-d6fa-cdaa-990a2fc12147@joeconway.com>
 <CAGB+Vh71kLZYq+vt=KB4n81PxG8Ty+ODtp_AM-Zzqf41GHK_Bg@mail.gmail.com>
 <744cf762-47d3-050f-5fa1-d4f9e8dbae2e@joeconway.com>
 <CAGB+Vh5MeDuUke6Y6PFLkyj-F_z06O=ROWyU-2QMi+ia6+RAPA@mail.gmail.com>
 <CAOuzzgqzTSwtnUwZXFL2Hx6M2TTTmK_SZyjp+AdTcQMhL_Eskg@mail.gmail.com>
 <6732fdfd-0ea4-941d-fd85-331ff48af5ce@joeconway.com>
 <CA+Tgmob_2p8k_r1C-bpuDT0g8moBNCQgXTLmfGH3wWfGtqrVOA@mail.gmail.com>
From: Joe Conway <mail@joeconway.com>
Subject: Re: [PATCH v2] use has_privs_for_role for predefined roles
In-Reply-To: 
 <CA+Tgmob_2p8k_r1C-bpuDT0g8moBNCQgXTLmfGH3wWfGtqrVOA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/8370d856-28cd-6884-c155-0cbdcc0b4d79%40joeconway.com>
Precedence: bulk

On 3/28/22 15:56, Robert Haas wrote:
> On Mon, Mar 21, 2022 at 4:15 PM Joe Conway <mail@joeconway.com> wrote:
>> Robert -- any opinion on this? If I am not mistaken it is code that you
>> are actively working on.
> 
> Woops, I only just saw this. I don't mind if you want to change the
> calls to is_member_of_role() in basebackup_server.c and
> basebackup_to_shell.c to has_privs_of_role().

Done as originally posted.

> On that last note, I did not find basebackup_to_shell.required_role 
> documented at all, and did not attempt to fix that.

I saw that Robert added documentation and it already reads correctly I 
believe, except possibly an unrelated issue:

8<--------------
      <para>
       A role which replication whose privileges users are required to 
possess
       in order to make use of the <literal>shell</literal> backup target.
       If this is not set, any replication user may make use of the
       <literal>shell</literal> backup target.
      </para>
8<--------------

Robert, should that actually be:
  s/role which replication/role with replication/
?

Joe