Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uowGk-00DLDb-D6 for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Aug 2025 03:47:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uowGj-00DVU3-PB for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Aug 2025 03:47:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uowGj-00DVTv-Fn for pgsql-hackers@lists.postgresql.org; Thu, 21 Aug 2025 03:47:18 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uowGh-0011bD-25 for pgsql-hackers@lists.postgresql.org; Thu, 21 Aug 2025 03:47:17 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-76e6cbb9956so497645b3a.0 for ; Wed, 20 Aug 2025 20:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755748033; x=1756352833; darn=lists.postgresql.org; h=organization:subject:from:to:content-language:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=YF72RRKYLH6+mKKoUCCC6N3J8ERPMs4D+SLGxO2hEIk=; b=kgTzP6puwAQmY4cZCE0GPXEjbwmSlSZ9kGXE5B6IjpDBVnnmcv3+RQ921AaSysV7CB IBgo3EE+Wc/krTaEksquiYB4/Kt0nX2YHboRkr9fmVhXZYZfPsIQBWFKwCpq+27BZAc6 RBhxQbI+hvIOFuxvbFuJKbE2xD7b9JmAYRWDiRvptxgZmnvcKoSXAIxb65XDX3C6yHAQ 46QMEgPPRxr+0k4ib8drhNOS39Y6Prs4bWQgmfV97T9xBALWc78R6aVe2AlTTVV+seOR KHWzdyEuZY2FMLDs7L0obo6etrx781ffmXQH17ScKJ9adD60ISmJbkdCMxCaG82RGWJS 1XKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755748033; x=1756352833; h=organization:subject:from:to:content-language:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YF72RRKYLH6+mKKoUCCC6N3J8ERPMs4D+SLGxO2hEIk=; b=sH2Ks69V8TB6ryHMF2EOhNZEwdHhx9wkvtMO/+IaT57E50F0p78CjnPe/OP/WoZyFa FN9kSusKLutBsYck+vo1jkEgQxywVV4yzy59gt/VN/mVELv37uWtN7hY3md9mOrg6CUR DAWLrDsQ57Vu+x/E9YgqpOLnrLCESGw62G4u0vVxGoGISrQR9wFfNVyrkYCMvKgjxEae 1Y79qvqCMuuY9BSKEd+yM3BmClqFbE19PKRxqfzRbH4vmxuC/fD/TJSIpcLqv/eOSz55 DJea4iWjQnuBEfU2Yox/LQieqhg4Ucilxm2gHnTsTE14Tf4CLk5kKuBAsZ30hM/7gfRc CRuA== X-Gm-Message-State: AOJu0Yye8J2E3iRlzSf2tcVJ/khFlHg8kJxzYaRFJNibqZS00CTM/qia 1hq5vAszH+q32o/z9FHrjGxlupWPcI/6/i+Xh2cq2TFwbKOHn01wXyCn+prc/ij+ X-Gm-Gg: ASbGncu6siA/pk82f2krTdt/Mkdr0Trz3SSIxEqr4UarRtEFC1Oa+YGfddzQXpaigyr XNkEL3K75BXYr2LJo2yg6tWL3tERvlBOYDj2cDUxLI7RBDBEjL8LcP+4hT9ss7lQgmFfMtcg5cz b37g3BsVErv/5JSgzmgLPI3geoF0ESf4EO/0zPzuyYaIXZgCAVhRGqgVOYabN0Xvu/YeG6o0xwR iHnoQPOa61CI8Qw2mBq/5TDeZhob+Io0cawwLAPa7lFYmeCwnfyQgBnWp/4M/ymddm6F6Zvcz3v tmAy8AgAB+PWfSn3mPtcCoJ/BtgDisXoGrP+RQcRp3wRvuH1WBh9YQMXTdDTCVtjuI5fvhs+abt HWwOxa9qOrWaJ73McBOkvJNGlNe1Q5BzI3SCHjRmev0motJqV X-Google-Smtp-Source: AGHT+IEx6YGeOJ6nQHp76RZnfVfyUd0IIMvdVgd8FFg8l69E/8wWyGY0+qVmg5aFp1shGVXx5KR0dg== X-Received: by 2002:a05:6a00:3c90:b0:748:323f:ba21 with SMTP id d2e1a72fcca58-76ea315b2abmr1245979b3a.1.1755748033088; Wed, 20 Aug 2025 20:47:13 -0700 (PDT) Received: from [10.0.0.120] ([27.223.148.204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76ea0c16351sm885399b3a.14.2025.08.20.20.47.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Aug 2025 20:47:12 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------SiA07f4ypAuNfxCoVPRhjQ8M" Message-ID: <83a14f3c-f347-4769-9c01-30030b31f1eb@gmail.com> Date: Thu, 21 Aug 2025 11:47:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pgsql-hackers@lists.postgresql.org From: Chao Li Subject: Remove redundant assignment in CreateWorkExprContext Organization: HighGo Software Co., Ltd. List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------SiA07f4ypAuNfxCoVPRhjQ8M Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, While discussing [1], I was reading execUtils.c, then I noticed this redundant local variable assignment in CreateWorkExprContext(). The attached patch fixed that. [1]: https://www.postgresql.org/message-id/CAA4eK1+SEus_6vQay9TF_r4ow+E-Q7LYNLfsD78HaOsLSgppxQ@mail.gmail.com Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/ --------------SiA07f4ypAuNfxCoVPRhjQ8M Content-Type: text/plain; charset=UTF-8; name="v1-0001-Remove-redundant-assignemnt-in-CreateWorkExprCont.patch" Content-Disposition: attachment; filename*0="v1-0001-Remove-redundant-assignemnt-in-CreateWorkExprCont.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1YjU0NjIzOTgxMTdhY2QwMjAzZTc2MGI3YmYxOGM0ZmY2MTZjZjgxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQ2hhbyBMaSAoRXZhbikiIDxsaWNAaGlnaGdvLmNv bT4KRGF0ZTogVGh1LCAyMSBBdWcgMjAyNSAxMTozNToxOCArMDgwMApTdWJqZWN0OiBbUEFU Q0ggdjFdIFJlbW92ZSByZWR1bmRhbnQgYXNzaWduZW1udCBpbiBDcmVhdGVXb3JrRXhwckNv bnRleHQKCkluIENyZWF0ZVdvcmtFeHByQ29udGV4dCgpLCBtYXhCbG9ja1NpemUgaXMgaW5p dGlhbGl6ZWQgdG8KQUxMT0NTRVRfREVGQVVMVF9NQVhTSVpFLCBhbmQgaXQgdGhlbiBpbW1l ZGlhdGVseSByZWFzc2lnbmVkLAp0aHVzIHRoZSBpbml0aWFsaXphdGlvbiBpcyBhIHJlZHVu ZGFudC4KCkF1dGhvcjogQ2hhbyBMaSA8bGljQGhpZ2hnby5jb20+Ci0tLQogc3JjL2JhY2tl bmQvZXhlY3V0b3IvZXhlY1V0aWxzLmMgfCA0ICstLS0KIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9l eGVjdXRvci9leGVjVXRpbHMuYyBiL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNVdGlscy5j CmluZGV4IGZkYzY1YzJiNDJiLi4wN2I2N2Q2NWI0MCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tl bmQvZXhlY3V0b3IvZXhlY1V0aWxzLmMKKysrIGIvc3JjL2JhY2tlbmQvZXhlY3V0b3IvZXhl Y1V0aWxzLmMKQEAgLTMyMSw5ICszMjEsNyBAQCBDcmVhdGVFeHByQ29udGV4dChFU3RhdGUg KmVzdGF0ZSkKIEV4cHJDb250ZXh0ICoKIENyZWF0ZVdvcmtFeHByQ29udGV4dChFU3RhdGUg KmVzdGF0ZSkKIHsKLQlTaXplCQltYXhCbG9ja1NpemUgPSBBTExPQ1NFVF9ERUZBVUxUX01B WFNJWkU7Ci0KLQltYXhCbG9ja1NpemUgPSBwZ19wcmV2cG93ZXIyX3NpemVfdCh3b3JrX21l bSAqIChTaXplKSAxMDI0IC8gMTYpOworCVNpemUJCW1heEJsb2NrU2l6ZSA9IHBnX3ByZXZw b3dlcjJfc2l6ZV90KHdvcmtfbWVtICogKFNpemUpIDEwMjQgLyAxNik7CiAKIAkvKiBCdXQg bm8gYmlnZ2VyIHRoYW4gQUxMT0NTRVRfREVGQVVMVF9NQVhTSVpFICovCiAJbWF4QmxvY2tT aXplID0gTWluKG1heEJsb2NrU2l6ZSwgQUxMT0NTRVRfREVGQVVMVF9NQVhTSVpFKTsKLS0g CjIuMzkuNSAoQXBwbGUgR2l0LTE1NCkKCg== --------------SiA07f4ypAuNfxCoVPRhjQ8M--