Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wg9JJ-005xk7-0w for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Jul 2026 22:58:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wg9JF-00B8rW-2X for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Jul 2026 22:58:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wg9JF-00B8rN-0r for pgsql-hackers@lists.postgresql.org; Sat, 04 Jul 2026 22:58:05 +0000 Received: from lahtoruutu.iki.fi ([185.185.170.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wg9JC-00000001X7V-1gMF for pgsql-hackers@lists.postgresql.org; Sat, 04 Jul 2026 22:58:04 +0000 Received: from [10.0.2.15] (unknown [130.41.208.2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4gt5cf4FQNz49Pyt; Sun, 05 Jul 2026 01:57:54 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1783205875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y2uYrGVKbQc78SnPlx1lyQ1iUfcoDnBr8EpQdmoKABk=; b=fv8ubWIc21L8KQeeJavZiC8FtK5l2DeAh/D0fUF7qDepDbxLL1R+g2OKM4Bg+4C2i90/WX JearGHWyCJgnO4X4ygU14TRaRUgLZpIoHwhVJs0g2G5HofpaJOXdOx2GXzeL7xKc1k2/5Y RICH3TbeBRsxylHn1c4/al0F/GxjTKp3wz6vLqHxCpXbESSJNpF/omRy1MLCzIORvIb8TC ZSVbPmBjVAs5kSaVwWudxoToYCNAh/4lcvd7WU7Ik0HtRqIalc/2J9C6N1REI3LbuC/7tU mAAE6FLGsn4lVOTYHRipSBLwgynlUqROCL1xNZoEKw1hbj4vQJinrXCRGNcrQA== ARC-Seal: i=1; a=rsa-sha256; d=iki.fi; s=lahtoruutu; cv=none; t=1783205875; b=ESVra0nPgP8YLI910mdy1N5QiOiumgqgGbjS4uclgGrsh3L/Pg5nxl9K2Csd3dgH4d5+cD 5Tl2QQ7M58Cg5drWIc9iCCr+0kVer7q7qVHihQxbP+I7Iy3s/FfDU2+h0jy3t0sZqwanr5 Eg1QT+3zDS0g84iUn6LllDs0PH4W7hE/RyprqZSCovBo6tc/KFLnv6C53wJu0W2w1Jebnb 1MzY+3VLHBqSHYEeaiLbOSBgzf2GgeUCsFcyroG6sdM1VJQeahk5YrTOveTOo+ZwtkwRr1 5+fcxXKx1fEOPbe2vcxyCG7HOJktEVEWVQi9YhjyxWZlhwlGHpW4xPmzuY7ZaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1783205875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y2uYrGVKbQc78SnPlx1lyQ1iUfcoDnBr8EpQdmoKABk=; b=oT8fzN8J5i5lO1ndl6yXEqmsEJeFHsht+7WEzjVIUFH3ptU8lznORB62mPfo3KlF2XzZPK 8iHm6pNEeqC01UNw1fbs5HLgqaV1E/1iV7xFrGGMlKBPqB4Zqc3AnZBCCCXm1/7bFNN+3x AXemI1zoL8OYtyCg6lT9L9jA58pAIQ/4DxoTP6mFn2Z4v7ulSpMCQ4+7sOkbGeR829QRpf tDbotWXkjZXQysmRVUidBefdVvlmy5L95AlbyOPtTMwX0wdavzXHfgdCjjPi4D1wtfXJnX P2xhDHFU9eHt/fGvWvySlvftyyURVSOXDY5WCI4CfknIogwKk1yiqZ6pltiB8g== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi Content-Type: multipart/mixed; boundary="------------TEJh210wyYQvpPC3LF336sWN" Message-ID: <83daa551-5f45-4683-920f-e62ed94b06a8@iki.fi> Date: Sun, 5 Jul 2026 01:57:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore To: Jelte Fennema-Nio Cc: PostgreSQL Hackers , Alvaro Herrera , Jacob Champion References: <88dfe280-ba29-4943-95b8-63abc9f3f771@iki.fi> <9d7ba3ac-d660-483e-8f68-9096a2464e90@iki.fi> Content-Language: en-US From: Heikki Linnakangas In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------TEJh210wyYQvpPC3LF336sWN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/07/2026 01:28, Jelte Fennema-Nio wrote: >> The comments you added in your patches help a lot, explaining the three >> different ways that cancellation can be handled, thanks for that. > > Yeah, I think I extracted just the comment in fe_utils/cancel.c to a separate patch, and modified it to reflect the reality before the rest of the changes. I'm inclined to commit that now to document the status quo. That'll also make it easier to see what the other patches change. Does the attached look correct to you? - Heikki --------------TEJh210wyYQvpPC3LF336sWN Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-comment-to-describe-the-various-frontend-cancel-.patch" Content-Disposition: attachment; filename*0="0001-Add-comment-to-describe-the-various-frontend-cancel-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1YjYyZTFiMDllMjMzZDliNDllNDM4MjY3ZmU5OTVlODQwMTExYWJmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZWlra2kgTGlubmFrYW5nYXMgPGhlaWtraS5saW5u YWthbmdhc0Bpa2kuZmk+CkRhdGU6IFN1biwgNSBKdWwgMjAyNiAwMTo0NDo0MiArMDMwMApT dWJqZWN0OiBbUEFUQ0ggMS8xXSBBZGQgY29tbWVudCB0byBkZXNjcmliZSB0aGUgdmFyaW91 cyBmcm9udGVuZCBjYW5jZWwKIG1ldGhvZHMKCkF1dGhvcjogSmVsdGUgRmVubmVtYS1OaW8g PHBvc3RncmVzQGplbHRlZi5ubD4KRGlzY3Vzc2lvbjogaHR0cHM6Ly93d3cucG9zdGdyZXNx bC5vcmcvbWVzc2FnZS1pZC9ESlBBSDBXUEpWM0suMVBZWjhQMFFYWlZNWEBqZWx0ZWYubmwK LS0tCiBzcmMvZmVfdXRpbHMvY2FuY2VsLmMgfCAzNCArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvZmVfdXRpbHMvY2FuY2VsLmMgYi9zcmMvZmVf dXRpbHMvY2FuY2VsLmMKaW5kZXggZTZiNzU0MzlmNTYuLjlmYWMwNGUzMzNlIDEwMDY0NAot LS0gYS9zcmMvZmVfdXRpbHMvY2FuY2VsLmMKKysrIGIvc3JjL2ZlX3V0aWxzL2NhbmNlbC5j CkBAIC0yLDkgKzIsMzkgQEAKICAqCiAgKiBRdWVyeSBjYW5jZWxsYXRpb24gc3VwcG9ydCBm b3IgZnJvbnRlbmQgY29kZQogICoKLSAqIEFzc29ydGVkIHV0aWxpdHkgZnVuY3Rpb25zIHRv IGNvbnRyb2wgcXVlcnkgY2FuY2VsbGF0aW9uIHdpdGggc2lnbmFsCi0gKiBoYW5kbGVyIGZv ciBTSUdJTlQuCisgKiBUaGlzIG1vZHVsZSBwcm92aWRlcyBTSUdJTlQvQ3RybC1DIGhhbmRs aW5nIGZvciBmcm9udGVuZCB0b29scyB0aGF0IG5lZWQgdG8KKyAqIGNhbmNlbCBxdWVyaWVz IG9yIGludGVycnVwdCBvdGhlciBvcGVyYXRpb25zLiAgSXQgcHJvdmlkZXMgdGhyZWUKKyAq IGluZGVwZW5kZW50IG1lY2hhbmlzbXMsIGFueSBjb21iaW5hdGlvbiBvZiB3aGljaCBjYW4g YmUgdXNlZCBieSBhbgorICogYXBwbGljYXRpb246CiAgKgorICogMS4gU2VydmVyIGNhbmNl bCBxdWVyeSByZXF1ZXN0IC0tIFdoZW4gYSBxdWVyeSBpcyBydW5uaW5nIGFuZCB0aGUgbWFp bgorICogICAgdGhyZWFkIGlzIHdhaXRpbmcgZm9yIHRoZSByZXN1bHQgb2YgdGhhdCBxdWVy eSBpbiBhIGJsb2NraW5nIG1hbm5lciwgd2UKKyAqICAgIHdhbnQgU0lHSU5UL0N0cmwtQyB0 byBjYW5jZWwgdGhhdCBxdWVyeS4gIFRoaXMgY2FuIGJlIGFjaGlldmVkIGJ5CisgKiAgICBj YWxsaW5nIFNldENhbmNlbENvbm4oKSB0byByZWdpc3RlciB0aGUgY29ubmVjdGlvbiB0aGF0 IGlzIChvciB3aWxsIGJlKQorICogICAgcnVubmluZyB0aGUgcXVlcnksIHByaW9yIHRvIHdh aXRpbmcgZm9yIHRoZSByZXN1bHQuICBXaGVuIFNJR0lOVC9DdHJsLUMKKyAqICAgIGlzIHJl Y2VpdmVkLCBhIGNhbmNlbCByZXF1ZXN0IGZvciB0aGlzIGNvbm5lY3Rpb24gd2lsbCB0aGVu IGJlIHNlbnQgZnJvbQorICogICAgdGhlIHNpZ25hbCBoYW5kbGVyIChvbiBXaW5kb3dzLCBm cm9tIGEgc2VwYXJhdGUgdGhyZWFkKS4gIFRoYXQgaW4gdHVybgorICogICAgd2lsbCB0aGVu IChhc3N1bWluZyBhIGNvLW9wZXJhdGluZyBzZXJ2ZXIpIGNhdXNlIHRoZSBzZXJ2ZXIgdG8g Y2FuY2VsCisgKiAgICB0aGUgcXVlcnkgYW5kIHNlbmQgYW4gZXJyb3IgdG8gdGhlIHdhaXRp bmcgY2xpZW50IG9uIHRoZSBtYWluIHRocmVhZC4KKyAqICAgIFRoZSBjYW5jZWwgY29ubmVj dGlvbiBpcyBhIHByb2Nlc3Mtd2lkZSBnbG9iYWwsIHNvIG9ubHkgb25lIGNvbm5lY3Rpb24K KyAqICAgIGNhbiBiZSB0aGUgY2FuY2VsIHRhcmdldCBhdCBhIHRpbWUuICBSZXNldENhbmNl bENvbm4oKSBzaG91bGQgYmUgY2FsbGVkCisgKiAgICB0byBkaXNhcm0gdGhlIG1lY2hhbmlz bSBhZ2FpbiBhZnRlciB0aGUgYmxvY2tpbmcgd2FpdCBoYXMgY29tcGxldGVkLgorICoKKyAq IDIuIENhbmNlbFJlcXVlc3RlZCBmbGFnIC0tIFRoZSBDYW5jZWxSZXF1ZXN0ZWQgZmxhZyBp cyBzZXQgdG8gdHJ1ZSB3aGVuZXZlcgorICogICAgU0lHSU5UIGlzIHJlY2VpdmVkLCBhbmQg Y2FuIGJlIGNoZWNrZWQgYnkgdGhlIGFwcGxpY2F0aW9uIGF0IGFwcHJvcHJpYXRlCisgKiAg ICB0aW1lcy4gIFRoZSBwcmltYXJ5IHVzZSBjYXNlIGZvciB0aGlzIGlzIHdoZW4gdGhlIGFw cGxpY2F0aW9uIGNvZGUgaXMKKyAqICAgIG5vdCBibG9ja2VkIChpbmRlZmluaXRlbHkpLCBi dXQgbmVlZHMgdG8gdGFrZSBhbiBhY3Rpb24gd2hlbiBDdHJsLUMgaXMKKyAqICAgIHByZXNz ZWQsIHN1Y2ggYXMgYnJlYWsgb3V0IG9mIGEgbG9uZyBydW5uaW5nIGxvb3AuCisgKgorICog My4gU2lnbmFsIGhhbmRsZXIgY2FsbGJhY2sgLS0gQSBjYWxsYmFjayBmdW5jdGlvbiBjYW4g YmUgcmVnaXN0ZXJlZCB3aXRoCisgKiAgICBzZXR1cF9jYW5jZWxfaGFuZGxlcigpLCB3aGlj aCB3aWxsIHRoZW4gYmUgY2FsbGVkIGRpcmVjdGx5IGZyb20gdGhlCisgKiAgICBzaWduYWwg aGFuZGxlciB3aGVuZXZlciBTSUdJTlQgaXMgcmVjZWl2ZWQuICBCZWNhdXNlIGl0IGlzIGNh bGxlZCBmcm9tIGEKKyAqICAgIHNpZ25hbCBoYW5kbGVyLCB0aGUgY2FsbGJhY2sgZnVuY3Rp b24gbXVzdCBiZSBhc3luYy1zaWduYWwtc2FmZS4gIE9uCisgKiAgICBXaW5kb3dzLCBpdCBp cyBjYWxsZWQgZnJvbSBhIHNlcGFyYXRlIHNpZ25hbC1oYW5kbGluZyB0aHJlYWQuICBOT1RF OiBUaGUKKyAqICAgIGNhbGxiYWNrIGlzIGNhbGxlZCBBRlRFUiBzZXR0aW5nIENhbmNlbFJl cXVlc3RlZCBidXQgQkVGT1JFIHNlbmRpbmcgdGhlCisgKiAgICBjYW5jZWwgcmVxdWVzdCB0 byB0aGUgc2VydmVyIChpZiBhcm1lZCBieSBTZXRDYW5jZWxDb25uKS4gIFRoaXMgbWVhbnMK KyAqICAgIHRoYXQgaWYgdGhlIGNhbGxiYWNrIGV4aXRzIG9yIGxvbmdqbXBzLCBubyBjYW5j ZWwgcmVxdWVzdCB3aWxsIGJlIHNlbnQKKyAqICAgIHRvIHRoZSBzZXJ2ZXIuCiAgKgogICog UG9ydGlvbnMgQ29weXJpZ2h0IChjKSAxOTk2LTIwMjYsIFBvc3RncmVTUUwgR2xvYmFsIERl dmVsb3BtZW50IEdyb3VwCiAgKiBQb3J0aW9ucyBDb3B5cmlnaHQgKGMpIDE5OTQsIFJlZ2Vu dHMgb2YgdGhlIFVuaXZlcnNpdHkgb2YgQ2FsaWZvcm5pYQotLSAKMi40Ny4zCgo= --------------TEJh210wyYQvpPC3LF336sWN--